Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.7.1 pypi package - the from blenderproc.scripts.visHdf5Files import vis_data in GifWriterUtility.py is commented out, but the source code is inconsistent. #1112

Open
guyleaf opened this issue Jun 13, 2024 · 1 comment
Labels
bug Something isn't working first answer provided

Comments

@guyleaf
Copy link

guyleaf commented Jun 13, 2024

Describe the issue

Hi,
I find from blenderproc.scripts.visHdf5Files import vis_data is commented out in the v2.7.1 pypi package.
But the source code in GitHub is inconsistent.

So, I guess the bug is in packaging workflow. It should not be commented out.

Reproduce

  1. Download blenderproc-2.7.1.tar.gz from https://pypi.org/project/blenderproc/#files
  2. Open blenderproc/python/writer/GifWriterUtility.py

image

Minimal code example

No response

Files required to run the code

No response

Expected behavior

image

BlenderProc version

v2.7.1

@guyleaf guyleaf added the question Question, not yet a bug ;) label Jun 13, 2024
@guyleaf guyleaf changed the title v2.7.1 pypi package - the from blenderproc.scripts.visHdf5Files import vis_data is commented out, but the source code is fine. v2.7.1 pypi package - the from blenderproc.scripts.visHdf5Files import vis_data in GifWriterUtility.py is commented out, but the source code is fine. Jun 13, 2024
@guyleaf guyleaf changed the title v2.7.1 pypi package - the from blenderproc.scripts.visHdf5Files import vis_data in GifWriterUtility.py is commented out, but the source code is fine. v2.7.1 pypi package - the from blenderproc.scripts.visHdf5Files import vis_data in GifWriterUtility.py is commented out, but the source code is fine. Jun 13, 2024
@guyleaf guyleaf changed the title v2.7.1 pypi package - the from blenderproc.scripts.visHdf5Files import vis_data in GifWriterUtility.py is commented out, but the source code is fine. v2.7.1 pypi package - the from blenderproc.scripts.visHdf5Files import vis_data in GifWriterUtility.py is commented out, but the source code is inconsistent. Jun 13, 2024
@cornerfarmer
Copy link
Member

Thanks for the hint. Will fix that in the next version.

@cornerfarmer cornerfarmer added bug Something isn't working first answer provided and removed question Question, not yet a bug ;) labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working first answer provided
Projects
None yet
Development

No branches or pull requests

2 participants