Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we create broken symlinks if --scandir is a relative path #1

Open
juleskers opened this issue Mar 15, 2019 · 0 comments
Open

we create broken symlinks if --scandir is a relative path #1

juleskers opened this issue Mar 15, 2019 · 0 comments

Comments

@juleskers
Copy link
Contributor

The test-crawl.sh script specifies ./data as scandir.
This results in relative paths being passed through the entire crawler. These are relative to the scandir, but we create the symlinks in the links subdir, without compensating for the shift, thus creating broken links.

This was masked in the production environment, because we only specify absolute paths there.

To fix: either

  • document and enforce scandir to always be absolute, or
  • compensate by absolute-ising the $file_to_link path just before making the symlink.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant