Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JobManagerHandler conversion #22

Open
8 tasks
chaen opened this issue Jun 29, 2023 · 1 comment · May be fixed by #296
Open
8 tasks

JobManagerHandler conversion #22

chaen opened this issue Jun 29, 2023 · 1 comment · May be fixed by #296
Assignees
@ryuwd
Labels
hackathon For hackathon

Comments

@chaen
Copy link
Contributor

chaen commented Jun 29, 2023 •
edited
Loading

Continue the implementation of the /jobs route.
Missing methods are:

  • getMaxParametricJobs: no need to implement in the router. The legacy adapter should query the CS directly.
  • submitJob(self, jobDesc): started, needs completion (JobParametersDB, JobLoggingDB, etc)
  • confirmBulkSubmission(self, jobIDs) : needs larger discussion about ParametricJobSubmission
  • rescheduleJob(self, jobIDs): POST to /jobs/{job_id}/reschedule and /jobs/reschedule for bulk
  • removeJob(self, jobIDs): Do we need both removeJob and deleteJob ? (If yes, can removeJob be a parameter of deleteJob)
  • deleteJob(self, jobIDs): see above
  • killJob(self, jobIDs): POST to /jobs/{job_id}/kill and /jobs/kill for bulk (see [1])
  • resetJob(self, jobIDs): Could this be a parameter to rescheduleJob?

[1] We could think of having killJob and rescheduleJob react to setStatus(kill) or setStatus(reschedule). We do not because in general, it is forbidden to set an arbitrary status. Kill and Reschedule are exceptions, that's why they have a dedicated API.
@chaen chaen added the help wanted Extra attention is needed label Jun 29, 2023
@chrisburr chrisburr mentioned this issue Jun 29, 2023
Open
3 tasks
@natthan-pigoux natthan-pigoux mentioned this issue Sep 5, 2023
Merged
@simon-mazenoux simon-mazenoux mentioned this issue Sep 12, 2023
Merged
@chrisburr chrisburr removed the help wanted Extra attention is needed label Oct 16, 2023
@fstagni fstagni added the hackathon For hackathon label Sep 15, 2024
@ryuwd ryuwd linked a pull request Sep 16, 2024 that will close this issue
Draft
6 tasks
@ryuwd
Copy link

ryuwd commented Sep 17, 2024 •
edited
Loading

In addition to a lot of refactoring:

  • getMaxParametricJobs: no need to implement in the router. The legacy adapter should query the CS directly.
    • Left this alone (TBD)
  • submitJob(self, jobDesc): started, needs completion (JobParametersDB, JobLoggingDB, etc)
    • Left this alone (TBD)
  • confirmBulkSubmission(self, jobIDs) : needs larger discussion about ParametricJobSubmission
    • Left this alone (TBD)
  • rescheduleJob(self, jobIDs): POST to /jobs/{job_id}/reschedule and /jobs/reschedule for bulk
    • TBD
  • removeJob(self, jobIDs): Do we need both removeJob and deleteJob ? (If yes, can removeJob be a parameter of deleteJob)
    • This has become a DELETE operation (DELETE /api/jobs, DELETE /api/jobs/{job_id})
  • deleteJob(self, jobIDs): see above
    • This has been removed in favour of single and bulk status change (PATCH /api/jobs/status, PATCH /api/jobs/{job_id/status)
  • killJob(self, jobIDs): POST to /jobs/{job_id}/kill and /jobs/kill for bulk (see [1])
    • removed in favour of single job and bulk status change (PATCH /api/jobs/status, PATCH /api/jobs/{job_id/status)
  • resetJob(self, jobIDs): Could this be a parameter to rescheduleJob?
    • TBD with rescheduleJob

@fstagni fstagni linked a pull request Sep 17, 2024 that will close this issue
Refactor Job manager routes #296
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryuwd ryuwd

Labels
hackathon For hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Job manager routes ryuwd/diracx
4 participants
@fstagni @chaen @chrisburr @ryuwd