-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the client send its version when calling the server #258
Comments
[project.entry-points."diracx.min_client_version"]
diracx = "1.2.3"
lhcbdirac = "5.6.7" |
Side note: I don't think we will have millions of them, but do we want the diracx headers to be easily distinguishable from others ? That is, do we want e.g. Also, this raises the question: what do we do in case there isn't a version ? (swagger, diracx-web) |
Yes, I already changed the name with |
I guess the server should check the |
Another point is that the entrypoints in the toml for the "min_client_version" cannot be a static string but: I hard coded it there for now: d0ff92f#diff-424d2a991980de5065c3b1e58f5066bf78641a4804b34bb5977be2ad95289ae7R483 |
The server should given an error if the client version is too old
The minimum version should be configured in the pyproject as a metadata such that the extension can overwrite it (
diracx.min_client_version
)The text was updated successfully, but these errors were encountered: