Convert age argument to number in rejuvenate.lua#1340
Merged
myk002 merged 2 commits intoDFHack:masterfrom Nov 28, 2024
Merged
Conversation
due to the less than comparison, age must be converted to a number or else any attempt to use that argument causes the script to fail with "attempt to compare string with number".
Contributor
Author
|
Trying to figure out why this deleted, sorry. New to doing PRs. Edit: reopened, sorry. Didn't expect renaming to mess with this. |
myk002
reviewed
Nov 27, 2024
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
Looks good! Could you also add a line to the Fixes section of changelog.txt?
Contributor
Author
I can do that. Thanks for your patience, this is my first PR and I'm still figuring stuff out. |
myk002
approved these changes
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
due to the less than comparison, age must be converted to a number or else any attempt to use that argument causes the script to fail with "attempt to compare string with number".