Merge pull request #5739 from ab9rf/utf8-console

fix windows console (#5737)

Author: ab9rf

docs/changelog.txt

@@ -62,6 +62,7 @@ Template for new versions:
 - `autoclothing`, `autoslab`, `tailor`: orders will no longer be created with a repetition frequency of ``NONE``
 
 ## Misc Improvements
+- General: DFHack will unconditionally use UTF-8 for the console on Windows, now that DF forces the process effective system code page to 65001 during startup
 
 ## Documentation
 

library/MiscUtils.cpp

@@ -653,20 +653,31 @@ std::string UTF2DF(const std::string &in)
         out.resize(pos);
     return out;
 }
-
-DFHACK_EXPORT std::string DF2CONSOLE(const std::string &in)
+static bool console_is_utf8()
 {
-    bool is_utf = false;
 #ifdef LINUX_BUILD
+    static bool checked = false;
+    static bool is_utf = false;
+    if (checked)
+        return is_utf;
+
     std::string locale = "";
     if (getenv("LANG"))
         locale += getenv("LANG");
     if (getenv("LC_CTYPE"))
         locale += getenv("LC_CTYPE");
     locale = toUpper_cp437(locale);
-    is_utf = (locale.find("UTF-8") != std::string::npos) ||
-             (locale.find("UTF8") != std::string::npos);
+    is_utf = (locale.find("UTF-8") != std::string::npos) || (locale.find("UTF8") != std::string::npos);
+    checked = true;
+    return is_utf;
+#else
+    return true; // Since DF 53.11, Windows console is always UTF-8
 #endif
+}
+
+DFHACK_EXPORT std::string DF2CONSOLE(const std::string &in)
+{
+    bool is_utf = console_is_utf8();
     return is_utf ? DF2UTF(in) : in;
 }