Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layouts og:image property's content attribute outputs asset_path as string, not interpreted #25

Open
jsugarman opened this issue Mar 24, 2023 · 1 comment

Comments

@jsugarman
Copy link

see code line

This line

    <%%= tag :meta, property: 'og:image', content: asset_path('images/govuk-opengraph-image.png') %>

generates html

<meta property="og:image" content="asset_path('images/govuk-opengraph-image.png')">

To fix we need it to interpret the asset_path i imagine so the resulting html looks something like:

<meta property="og:image" content="/assets/images/govuk-opengraph-image-7802ee6164ac49920a8f1a71a3d148dc70e23963.png">
@peteryates
Copy link
Member

This seems like it's working to me now @jsugarman. Sorry for the massive delay, nobody's been keeping an eye on this repo.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants