Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency ClosedXML to 0.104.2 - autoclosed #620

Closed
wants to merge 1 commit into from
Closed

Update dependency ClosedXML to 0.104.2 - autoclosed #620

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 18, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ClosedXML 0.102.3 -> 0.104.2 age adoption passing confidence

Release Notes

ClosedXML/ClosedXML (ClosedXML)

v0.104.2

Compare Source

What's Changed

Full Changelog: ClosedXML/ClosedXML@0.104.1...0.104.2

v0.104.1

Compare Source

Release notes from 0.102.1 to the 0.104.1.

Summary of breaking changes is available at docs.closedxml.io:

OpenXML SDK

OpenXML SDK has released version 3. The 0.104.0 uses it as a dependency.

XLParser replaced with ClosedParser

The XLParser has been replaced with ClosedParser. The key benefits are

  • performance - ~2μs/formula, it's likely formulas will be parseable on the demand, necessary for construction of dependency tree
  • A1/R1C1 parsing parity - both modes can be parsed with no problems
  • AST oriented - it's likely a construction of AST in memory won't even be necessary, just use AST factory to evaluate formula directly

There is also a visualizer to display AST in a browser at https://parser.closedxml.io

image

Formula Calculation

In previous version, formulas used to be calculated recursively. Each formula checked it's supporting cells for other formulas and if there were some, they were recursively evaluated. There was some logic to decrease number of evaluations. That works for a very simple cases, but isn't very good for various non-happy paths (i.e. cells weren't calculated when they should be).

This version has replaced it with a standard

  • dependency tree for checking which formulas are dirty and need to be recalculated
  • calculation chain that manages dependencies and order of formulas during calculation

For more info, see docs, the Microsoft has a page about principles Excel Recalculation
and there is one with API at docs.closedxml.io.

image

Structured references

New parser also allows a basic evaluation of structured references. Format of structured reference must use official grammar, not Excel friendly names (e.g. Pastry[@​Name] is user-friendly name for Pastry[[#This Row],[Name]]). It's now possible to

using var wb = new XLWorkbook();
var ws = wb.AddWorksheet();
ws.Cell("A1").InsertTable(new Pastry[]
{
    new("Cake", 14),
    new("Waffle", 3),
}, "Pastry");

ws.Cell("D1").FormulaA1 = "SUM(Pastry[Price])";
ws.Cell("D3").FormulaA1 = "\"Pastry \" & Pastry[[#This Row],[Name]]";
wb.RecalculateAllFormulas();

Console.WriteLine($"Expected: {17}, Actual: {ws.Cell("D1").Value}");
Console.WriteLine($"Expected: \"Pastry Waffle\", Actual: {ws.Cell("D3").Value}");

Expected: 17, Actual: 17
Expected: "Pastry Waffle", Actual: Pastry Waffle

Renaming sheet updates formulas

When a sheet is renamed, a formula referencing the sheet is also updated. This is a part of long term effort to fix effects of structural changes of a workbook. It will be a long road (e.g. sheet still delete doesn't swicth to #REF!),** but is one of basic features that should be working acorss the board.

using var wb = new XLWorkbook();
var sheet = wb.AddWorksheet();
var anotherSheet = wb.AddWorksheet("Another");
sheet.Cell("A1").FormulaA1 = "Another!B4";
anotherSheet.Name = "Changed";
Console.WriteLine(sheet.Cell("A1").FormulaA1);

Changed!B4

Workbook structure

Internal structure has been cleaned up and optimized.

The dirty tracking has been moved out of cells to formulas and thus memory taken up by a single cell value is now only 16 bytes instead of 24 (?) bytes in 0.102. Of course there are some other structures around that take up memory as well, but the single cell value is now 16 bytes (I hoped for 8, but not feasible with double, DateTime and TimeSpan as possible cell values - all take up 8 bytes... not enough bits).

The same string in different instances is now not duplicated, but only one instance is used. As seen on following test, it can lead to significant decrease in memory consumption. 250k rows with 10 text rows (same string, different instance): 117 MiB om 0.103 vs 325 MiB in 0.102.1.

InsertData performance

Insert 250k rows of 10 columns of text and 5 columns of numbers (gist).

Description Rows Columns Time/Memory to insert data Save workbook Total time/memory
0.103.0-beta 250 000 15 1.619 sec / 117 MiB 6.343 sec 477 MiB
0.102.1 250 000 15 7.160 sec / 325 MiB 6.676 sec 692 MiB

Loading of cells is now done through streaming

Basically workbooks with a large amount of cells should see ~15%-20% speedup (as long as there are mainly values, not styles or OLAP metadata....).

Reading the 250k from previous chapter:

Description Rows Columns Time to load data Used memory
0.103.0-beta 250 000 15 15.648 sec 236 MiB
0.102.1 250 000 15 20.460 sec 329 MiB

Of course, this includes all stuff from 0.103.0-beta. Version 0.103 never got a non-beta release.

Pivot tables

The internal structure of pivot tables, along with most other features, has been completely overhauled. This update should significantly reduce crashes when loading and saving workbooks containing pivot tables.

The main issue with the previous internal structure was that it didn't align with the structure used by OOXML. This was problematic because we need to support all valid files. As a result, we have to handle a wide range of inputs and correctly convert them to our internal structure, which is rather hard. A more clear 1:1 mapping with OOXML is much simpler and more reliable.

AutoFilter

The Autofilter feature has been revamped, which includes some API changes. Its behavior is now more closely aligned with how Excel operates. The XML documentation provides detailed explanations, and there is a dedicated documentation page. Several bugs have also been fixed.

For more details, refer to the Autofilter section of the migration guide.

Source link

Although ClosedXML still doesn't have source package (Fody static weaving causes pdb mismatch and nuget will refuse symbol package), there is a source link info in the package.

SourceLink basically takes a repository and a commit from the package and retrieves source from directly from forge (in this case GitHub).

CommonCrawl dataset

When workbook is a valid one, ClosedXML shouldn't throw on load. That is a rather high priority (more than saving or manipulation). Unfortunately, that is hard to find such areas that cause most problems.

One of activities that was going in a background is trying to use excel files around the internet (found by CommonCrawl) to evaluate how bad it is. There aren't results yet, but it is something that is going on.

What's Changed

Technical debt

Performance improvements

Features

Bugfixes

Documentation

Breaking changes

AutoFilter

Formulas

Functions

Dependencies

Fixes

Pivot tables

New Contributors

Full Changelog: ClosedXML/ClosedXML@0.104.0-preview2...0.104.0-rc1

v0.104.0

Compare Source

Configuration

📅 Schedule: Branch creation - "* 0-3 * * 1" in timezone Europe/London, Automerge - "after 10am every weekday,before 4pm every weekday" in timezone Europe/London.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from dneed-nimble as a code owner November 18, 2024 01:52
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from 72c0ede to a49b634 Compare November 19, 2024 15:19
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from a49b634 to eab1f5c Compare November 21, 2024 09:31
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from eab1f5c to aa098a7 Compare November 21, 2024 10:19
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from aa098a7 to c9fdf35 Compare November 21, 2024 11:10
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from c9fdf35 to 31e5cf2 Compare November 21, 2024 12:03
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from 31e5cf2 to 3d7e9a8 Compare November 22, 2024 01:54
@renovate renovate bot changed the title Update dependency ClosedXML to 0.104.1 Update dependency ClosedXML to 0.104.2 Nov 22, 2024
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from 3d7e9a8 to 732e22b Compare November 27, 2024 17:43
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from 732e22b to 1c070ee Compare November 28, 2024 10:01
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from 1c070ee to 392046e Compare November 28, 2024 16:02
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from 392046e to aedeaee Compare December 2, 2024 17:49
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from aedeaee to dca2af9 Compare December 3, 2024 09:49
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from dca2af9 to 7a4eb01 Compare December 3, 2024 13:38
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from 7a4eb01 to 5a35d7b Compare December 3, 2024 14:35
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from 5a35d7b to 464e6e1 Compare December 4, 2024 15:47
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from 464e6e1 to 44c9640 Compare December 5, 2024 13:14
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from 44c9640 to eaabe85 Compare December 5, 2024 15:24
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from eaabe85 to cd0b1cc Compare December 5, 2024 15:26
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from cd0b1cc to 1ca8be0 Compare December 6, 2024 10:46
@renovate renovate bot force-pushed the renovate/closedxml-0.x branch from 1ca8be0 to 67ec705 Compare December 6, 2024 13:55
@renovate renovate bot changed the title Update dependency ClosedXML to 0.104.2 Update dependency ClosedXML to 0.104.2 - autoclosed Dec 10, 2024
@renovate renovate bot closed this Dec 10, 2024
@renovate renovate bot deleted the renovate/closedxml-0.x branch December 10, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dneed-nimble dneed-nimble Awaiting requested review from dneed-nimble

@dynamictulip dynamictulip Awaiting requested review from dynamictulip dynamictulip is a code owner

@nwarms nwarms Awaiting requested review from nwarms

Assignees
No one assigned
Labels
dependencies renovate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants