Fix Sentry not sending events #5330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwrw
approved these changes
Nov 25, 2024
leandroalemao
approved these changes
Nov 25, 2024
There is a bug in the JS event filtering; we get an error that `Error` is not defined. I expect this maybe should be a `TypeError` as in the other JS-related before-send method, but I'm not certain. Removing for now so that we start getting Sentry events through again.
ethax-ross
force-pushed
the
fix-sentry
branch
from
89b1a84
to
bd9eb08
Compare
|
Review app deployed to https://cpd-ecf-review-5330-web.test.teacherservices.cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the JS event filtering; we get an error that
Erroris not defined. I expect this maybe should be aTypeErroras in the other JS-related before-send method, but I'm not certain.Removing for now so that we start getting Sentry events through again.
Reverts #4968