Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler defaul error message #106

Open
marcomass opened this issue Feb 3, 2018 · 2 comments
Open

Compiler defaul error message #106

marcomass opened this issue Feb 3, 2018 · 2 comments
Assignees

Comments

@marcomass
Copy link
Contributor

The default message for and error in the compiler seems to be "Missing ";" character at the end of the query".
This is somehow misleading when the error is actually different, e.g. in the case of missing operator () such as "R = UNION A B;" instead of "R = UNION() A B;", or use of | in metadata attribute names such as "manually_curated|dataType" instead of "manually_curated__dataType".
Can these cases (and possibly others) be addressed with a specific error message, and somehow change the default error message to differentiate it from the one of a specific error?

@pp86
Copy link
Contributor

pp86 commented Feb 4, 2018

I do agree that the error report in case of syntax error sometimes is not to helpful; but it is really a hard task to design a parser that understands what it is wrong. Infact the parser is implemented as a white list of valid syntax constructs, not as a black list of invalid constructs.

Understanding why none of the rules was match is an extremely hard task.

I you have any better message to be shown as default one, I will substitute it.

Also, I move label this as "enhancement" since it does not provide a wrong result.

@marcomass
Copy link
Contributor Author

@pp86 Thank you for the clarification.
For the default error message, I suggest to use something different from any specific error (such as the absence of the final ";"), e.g., what do you think about a generic "Error at line ...."?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants