Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use number server to lookup DCLP files #346

Open
Edelweiss opened this issue Nov 22, 2017 · 9 comments
Open

Use number server to lookup DCLP files #346

Edelweiss opened this issue Nov 22, 2017 · 9 comments

Comments

@Edelweiss
Copy link

Make use of the number server when calling up dclp records

./app//controllers/publications_controller.rb:101:    if !(/papyri\.info\/dclp/ =~ identifier) # cromulent dclp hack to circumvent number server
./app//models/dclp_meta_identifier.rb:60:  # cl: CROMULENT DCLP ‘View in PN’ hack
./app//models/dclp_text_identifier.rb:18:  # cl: CROMULENT DCLP ‘View in PN’ hack
./app//models/dclp_text_identifier.rb:148:  # cl: CROMULENT DCLP ‘View in PN’ hack

Get Catalog Link

@Edelweiss Edelweiss self-assigned this Nov 22, 2017
@Edelweiss Edelweiss added this to the Merge Two milestone Jan 24, 2018
@Edelweiss
Copy link
Author

DCLP/navigator@2b4dca9

@Edelweiss
Copy link
Author

Edelweiss commented Feb 15, 2018

see Hugh’s comment in #360

@Edelweiss Edelweiss removed the blocked label Feb 28, 2018
@Edelweiss
Copy link
Author

blocks #334

@Edelweiss
Copy link
Author

Edelweiss commented Mar 15, 2018

With the number server working for DCLP, ddb files and hgv files get picked up alonside translations when calling up a DCLP file in the editor (see pink box):

bildschirmfoto 2018-03-15 um 13 10 17

This behaviour needs to be changed so that only translations are picked up.

@Edelweiss
Copy link
Author

Edelweiss commented Mar 15, 2018

Change url of numbers server and xpath
https://github.com/DCLP/sosol/tree/issue360

use numbers server for DCLP
https://github.com/DCLP/sosol/tree/issue346

@Edelweiss
Copy link
Author

good test case TM no. 129793 (DCLP file that has relations to DDB, HGV and HGV_trans)

@Edelweiss
Copy link
Author

Edelweiss commented Mar 15, 2018

When a translation is loaded alongside a DCLP record, the translation get the lead position (appearing in the title, being listed as the first item on the overview page, jumping automatically to the translations section after creation, see pink boxes)

bildschirmfoto 2018-03-15 um 14 04 56

@Edelweiss
Copy link
Author

merged to development and master

https://github.com/DCLP/sosol/tree/development
https://github.com/DCLP/sosol/tree/master

Can now be tested on DCLP test

@Edelweiss Edelweiss assigned jcowey and rla2118 and unassigned Edelweiss Mar 15, 2018
@Edelweiss
Copy link
Author

can also be tested on production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants