Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add EEPROM Functionality to ARDUINO_ARCH_ESP32 #367

Open
schwefeljm opened this issue Nov 12, 2023 · 4 comments
Open

Comments

@schwefeljm
Copy link

I have worked on this and have a branch locally I would like to push upstream to get feedback on.
It turned out to be pretty simple and allows for up to 64k of EERPROM storage.

Please advise on how I should proceed.

Thank you,

Jason

@habazut
Copy link
Contributor

habazut commented Nov 12, 2023

Fork the CS repo to your github and then push your local branch there and we'll have a look at it.

It is probably simple. If I remember correct, on ESP32 one needs to commit all changes to EEPROM in a seperate call as writes do not immidiately get copied to persistent storage.

Harald.

@schwefeljm
Copy link
Author

@habazut - Git is saying "You do not have permissions to push to 'DCC-EX/CommandStation-RX' on Github"

@habazut
Copy link
Contributor

habazut commented Nov 12, 2023

Of course not. Fork out repo to your repo, add a new upstream definition from your local and push to your repo

git remote add myforkrepo [email protected]:schwefeljm/CommandStation-EX
git push myforkrepo 

Harald.

@schwefeljm
Copy link
Author

Understood. I am used to the model we use at work where (mostly) anyone can push a branch, but main is protected and requires PR, approvals, etc.

Here it is:
https://github.com/schwefeljm/CommandStation-EX/tree/esp32-eeprom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants