Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values of the @function attribute of the <metamark> element in examples #214

Open
daliboris opened this issue Feb 20, 2024 · 4 comments
Open

Comments

@daliboris
Copy link
Contributor

I looked at the <metamark> element in the examples in the Guidelines and found very similar main names for the @function attribute. i.e. Marker, Separtator, Delimiter:

<metamark function="exampleMarker">○</metamark>
<metamark function="relatedEntryMarker">○</metamark>
<metamark function="subentryMarker">■</metamark>
<metamark function="entrySeparator">◆</metamark>
<metamark function="senseSeparator">◆</metamark>
<metamark function="senseDelimiter">§</metamark>
<metamark function="lemmaDelimiter">,</metamark>

Is the difference between Marker, Separator and Delimiter so significant that we should keep them all, or can we just use one or two preferred names?

@anacastrosalgado
Copy link
Collaborator

In my opinion, Delimiter is enough and I have arguments in favour.

@ttasovac
Copy link
Contributor

ttasovac commented Feb 22, 2024

I'm ok with unifying this in the examples and using "Delimiter". The values of the function attribute here are not hard-coded in the schema, but I do see the benefit of uniformity in the values we use in the examples.

Boris, shall we use this simple update to refresh your knowledge of the workflow we discussed a while back? You would need to:

  • create a feature branch based off dev
  • make the changes in the example file (examples.xml only; the "stripped" version, i.e. one without the TEI namespace, which is needed for inclusion into egXML elements, will be created automatically using oXygen transformations)
  • start a new <listChange> for version 0.9.4 in <revisionDesc> in TEILex0.odd
  • generate the rng schema and html documentation using the two TEI Lex-0 transformation scenarios in oXygen
  • make a PR

I would then check the PR and merge it into the dev branch. As you may remember, I'm not merging individual commits into master. We do individual commits into dev, and then periodically merge the dev branch as a new release into the master.

@daliboris
Copy link
Contributor Author

Hi @ttasovac, just noticed this assignment for me. I will try to do my best (in the next week?).

@ttasovac
Copy link
Contributor

ttasovac commented Jun 9, 2024

@daliboris just a small reminder...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants