Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ergonomics] profile driver and base module imports #1246

Open
skrawcz opened this issue Dec 2, 2024 · 2 comments
Open

[ergonomics] profile driver and base module imports #1246

skrawcz opened this issue Dec 2, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed repo-hygiene

Comments

@skrawcz
Copy link
Collaborator

skrawcz commented Dec 2, 2024

Current behavior

It takes ~2 seconds to do:

from hamilton import driver, base

We should profile this and see where the time is being spent.

Library & System Information

Latest hamilton on macOS, python 3.10.

Expected behavior

It should load in < 1 second.

Additional context

This is a quality of life task.

This task requires:

  1. to use a profiler to figure out where time is being spent
  2. report the results
  3. provide recommendations
@skrawcz skrawcz added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed repo-hygiene labels Dec 2, 2024
@elijahbenizzy
Copy link
Collaborator

elijahbenizzy commented Dec 2, 2024

Blech, pandas gets imported regardless. Second time importing after a fresh install it's faster, but still not great.

First time:
image

Second time:
image

@skrawcz
Copy link
Collaborator Author

skrawcz commented Dec 2, 2024

import pandas as pd

Takes ~1 second for me. So that's not all of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed repo-hygiene
Projects
None yet
Development

No branches or pull requests

2 participants