Skip to content
This repository has been archived by the owner on Jan 10, 2020. It is now read-only.

Not all Notificaiton class have Interface OSNotificationServiceInterface::sendMessages(array $messages) #3

Closed
snakewa opened this issue Nov 1, 2013 · 3 comments
Closed

Not all Notificaiton class have Interface OSNotificationServiceInterface::sendMessages(array $messages) #3

snakewa opened this issue Nov 1, 2013 · 3 comments

Comments

@snakewa
Copy link

snakewa commented Nov 1, 2013

AndroidNotification and BlackberryNotification does not have sendMessages implemented, so I guess sendMessages() should be optional or AndroidNotification and BlackberryNotification should implement it and throw an exception when they are invoked.

Because this will cause an error when Symfony2 try to compile them
@bassrock
Copy link
Member

bassrock commented Nov 4, 2013

Agreed. And if someone wants to create a pull request with this functionality, I would be happy to merge it.

@bassrock
Copy link
Member

Referencing this pull request #4

@bassrock
Copy link
Member

@snakewa see #7 this will be included in there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snakewa @bassrock