Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes on how missing information are reported #7

Closed
wants to merge 0 commits into from

Conversation

CyrilleB79
Copy link
Owner

Link to issue

Fixes #5

Description of the issue

  • Missing information in the table clutter the result.
  • One may remove the row with no information
  • Also, using question mark (?) in the result is not a good idea because nothing is spoken.

Solution

  • In Unicode data table, I have removed the question marks appearing when there is no data file available, e.g.:
    • name of character in languages other than English and French
    • CLDR name for languages without CLDR data in NVDA such as Aragonese
  • I do not want to totally remove the row or the information when there is a data file for a language but no information for a specific character, e.g. 'A' in CLDR. This means: "There is a CLDR file for your language, e.g. English, but no CLDR information for this specific character".

Remaining questions

  • What would the best way to report missing character information (in Unicode table)? So that it could be heard but remaining light.
  • While at it what would be the best way to report "[No file]" and "[Not defined]"?

@lukaszgo1, your opinion would be valuable if possible. Thanks. You can test the new version of the add-on in master branch, or better, in the branch of this PR.

@CyrilleB79 CyrilleB79 closed this Jan 31, 2023
@CyrilleB79 CyrilleB79 deleted the reportMissingInfo branch February 20, 2023 14:46
@lukaszgo1
Copy link
Contributor

Hi @CyrilleB79 Sorry for not responding earlier - the last, and thankfully final term of my engineering studies was an absolute nightmare, so I'm in the process of catching up with various NVDA related things which I've neglected in the last few months. What is the status here exactly - it looks like this PR makes no code changes (seems all of them are merged into master)? Are questions which you've asked in the initial comment still relevant?

@CyrilleB79 CyrilleB79 restored the reportMissingInfo branch February 22, 2023 16:06
@CyrilleB79 CyrilleB79 deleted the reportMissingInfo branch February 22, 2023 16:12
@CyrilleB79
Copy link
Owner Author

Sorry, seems that I had forgotten that this branch was associated with a PR. Probably I had just worked in it and merged it without solving all the questions in this PR.

Let's discuss further the issue in #5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider omitting not applicable rows rather than displaying question marks
2 participants