Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is AutomaticRecoveryEnabled explicitly set to false? #11

Open
tafs7 opened this issue Dec 14, 2018 · 1 comment
Open

Why is AutomaticRecoveryEnabled explicitly set to false? #11

tafs7 opened this issue Dec 14, 2018 · 1 comment

Comments

@tafs7
Copy link

tafs7 commented Dec 14, 2018

@CymaticLabs @meverett, I just realized that ConnectionFactory.AutomaticRecoveryEnabled is explicitly set to false:

Also, there's no property in this RabbitMqBrokerConnection wrapper that enables the consumer of this lib to set that RMQ client property via code.

Is there any specific reason why this was set to false explicitly for this wrapper? was there a concern with Unity and the broker connection during recovery?

I'd like to understand the reasoning for that decision, before I go and fork and change that myself and find some odd/edge-case issue that you may have already come up with and why you may have set this to false from the beginning.

thanks!

@tafs7
Copy link
Author

tafs7 commented Dec 18, 2018

Bueller? Bueller? Anyone?
@CymaticLabs @meverett

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant