Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC: drop support for node<18 #1081

Open
jkowalleck opened this issue May 30, 2024 · 1 comment
Open

BC: drop support for node<18 #1081

jkowalleck opened this issue May 30, 2024 · 1 comment
Assignees

Comments

@jkowalleck
Copy link
Member

jkowalleck commented May 30, 2024

node < 18 is no longer maintained.
see https://github.com/nodejs/nodejs.org/blob/main/pages/en/about/previous-releases.mdx

lets drop support for node < 18

idea:

  • Support node versions greater equal last active release -- so that all implemented features are included, and maintenance releases are compatible
  • and so on

(this might enable more up-to-date developer experience, and updates in some [dev-]dependencies)

@jkowalleck
Copy link
Member Author

reminder: remove unused cases and the whole usage of npm_config_engine_strict=false
in the workflows

run: |
set -ex
# for the purpose of testing strange setups,
# we need to craft compatible versions by hand,
# and might utilize `npm_config_engine_strict=false`
dev_constraints=' npm-run-all2 c8 mocha fast-glob '
# as long as npm cannot auto-resolve engine-constraints, we need to help here
case "$NODE_VERSION" in
'16')
dev_constraints="${dev_constraints/ c8 / c8@^9 }"
;;
'14')
dev_constraints="${dev_constraints/ c8 / c8@^9 }"
dev_constraints="${dev_constraints/ npm-run-all2 / npm-run-all2@^5 }"
;;
'14.0.0')
dev_constraints="${dev_constraints/ c8 / c8@^8 }"
dev_constraints="${dev_constraints/ npm-run-all2 / npm-run-all2@^5 }"
export npm_config_engine_strict=false
;;
esac
echo "::group::install prod"
npm_config_engine_strict=false npm i --ignore-scripts --include=optional --omit=dev --only=prod --production --loglevel=silly
echo "::endgroup::"
echo "::group::install dev"
npm i --ignore-scripts --loglevel=silly --no-save $dev_constraints
echo "::endgroup::"
echo "::group::rebuild libxmljs2"
## rebuild deps for which scripts were ignored, or partially installed - since "ignore-scripts" was used
npm rebuild --loglevel=silly libxmljs2 || npm uninstall --no-save libxmljs2
echo "::endgroup::"
- name: fetch build artifact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant