From cd7df5d17e9fbd4f9df2774ae7399b902a37e20b Mon Sep 17 00:00:00 2001
From: cccs-br <benoit.roy@cyber.gc.ca>
Date: Fri, 5 Apr 2024 14:09:19 -0400
Subject: [PATCH 1/4] blah

---
 pom.xml                                       | 56 +++++++++----------
 .../msgpack/suite/MessagePackDataSuite.scala  |  1 -
 2 files changed, 27 insertions(+), 30 deletions(-)

diff --git a/pom.xml b/pom.xml
index 2f39063..f099574 100644
--- a/pom.xml
+++ b/pom.xml
@@ -34,13 +34,14 @@
   <properties>
     <gpg.skip>true</gpg.skip>
     <java.version>11</java.version>
+    <!-- <scala.version>2.12.18</scala.version> -->
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
   </properties>
   <dependencies>
     <dependency>
       <groupId>org.scala-lang</groupId>
       <artifactId>scala-library</artifactId>
-      <version>2.12.10</version>
+      <version>2.12.18</version>
     </dependency>
     <dependency>
       <groupId>org.apache.spark</groupId>
@@ -81,7 +82,7 @@
     <dependency>
       <groupId>org.scalatest</groupId>
       <artifactId>scalatest_2.12</artifactId>
-      <version>3.2.15</version>
+      <version>3.2.18</version>
       <scope>test</scope>
     </dependency>
   </dependencies>
@@ -95,7 +96,7 @@
       <url>https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/</url>
     </repository>
   </distributionManagement>
-  <repositories>
+  <!-- <repositories>
     <repository>
       <id>scala-tools.org</id>
       <name>Scala-tools Maven2 Repository</name>
@@ -108,38 +109,18 @@
       <name>Scala-tools Maven2 Repository</name>
       <url>http://scala-tools.org/repo-releases</url>
     </pluginRepository>
-  </pluginRepositories>
+  </pluginRepositories> -->
   <build>
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
+        <version>3.8.0</version>
         <configuration>
           <source>${java.version}</source>
           <target>${java.version}</target>
         </configuration>
       </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-source-plugin</artifactId>
-        <executions>
-          <execution>
-            <id>attach-sources</id>
-            <phase>verify</phase>
-            <goals>
-              <goal>jar-no-fork</goal>
-            </goals>
-          </execution>
-        </executions>
-      </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-surefire-plugin</artifactId>
-        <version>2.7</version>
-        <configuration>
-          <skipTests>true</skipTests>
-        </configuration>
-      </plugin>
       <plugin>
         <groupId>net.alchim31.maven</groupId>
         <artifactId>scala-maven-plugin</artifactId>
@@ -149,19 +130,36 @@
             <goals>
               <goal>compile</goal>
               <goal>testCompile</goal>
-              <goal>doc-jar</goal>
             </goals>
           </execution>
         </executions>
-      </plugin>
+        <!-- <configuration>
+          <scalaVersion>${scala.version}</scalaVersion>
+        </configuration>         -->
+      </plugin>  
       <plugin>
         <groupId>org.scalatest</groupId>
         <artifactId>scalatest-maven-plugin</artifactId>
-        <version>2.0.2</version>
+        <version>2.2.0</version>
         <configuration>
           <reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
           <junitxml>.</junitxml>
           <filereports>WDF TestSuite.txt</filereports>
+          <argLine>
+            --add-opens=java.base/java.lang=ALL-UNNAMED
+            --add-opens=java.base/java.lang.invoke=ALL-UNNAMED
+            --add-opens=java.base/java.lang.reflect=ALL-UNNAMED
+            --add-opens=java.base/java.io=ALL-UNNAMED
+            --add-opens=java.base/java.net=ALL-UNNAMED
+            --add-opens=java.base/java.nio=ALL-UNNAMED
+            --add-opens=java.base/java.util=ALL-UNNAMED
+            --add-opens=java.base/java.util.concurrent=ALL-UNNAMED
+            --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED
+            --add-opens=java.base/sun.nio.ch=ALL-UNNAMED
+            --add-opens=java.base/sun.nio.cs=ALL-UNNAMED
+            --add-opens=java.base/sun.security.action=ALL-UNNAMED
+            --add-opens=java.base/sun.util.calendar=ALL-UNNAMED
+          </argLine>
         </configuration>
         <executions>
           <execution>
@@ -171,7 +169,7 @@
             </goals>
           </execution>
         </executions>
-      </plugin>
+      </plugin>        
       <plugin>
         <groupId>org.sonatype.plugins</groupId>
         <artifactId>nexus-staging-maven-plugin</artifactId>
diff --git a/src/test/scala/org/apache/spark/sql/msgpack/suite/MessagePackDataSuite.scala b/src/test/scala/org/apache/spark/sql/msgpack/suite/MessagePackDataSuite.scala
index f5a5ccc..3c61e04 100644
--- a/src/test/scala/org/apache/spark/sql/msgpack/suite/MessagePackDataSuite.scala
+++ b/src/test/scala/org/apache/spark/sql/msgpack/suite/MessagePackDataSuite.scala
@@ -22,5 +22,4 @@ class MessagePackDataSuite extends AnyFunSuite {
     oneRow.delete()
     assert(oneRow.onFs === false)
   }
-
 }

From 995a5b23de85e1b4e55d2d619c96159644135ce4 Mon Sep 17 00:00:00 2001
From: cccs-br <benoit.roy@cyber.gc.ca>
Date: Fri, 5 Apr 2024 15:07:06 -0400
Subject: [PATCH 2/4] Java17, cleaned up pom.

---
 .run/Template ScalaTest.run.xml | 25 +++++++++++++++++++++
 pom.xml                         | 39 ++++++---------------------------
 2 files changed, 32 insertions(+), 32 deletions(-)
 create mode 100644 .run/Template ScalaTest.run.xml

diff --git a/.run/Template ScalaTest.run.xml b/.run/Template ScalaTest.run.xml
new file mode 100644
index 0000000..5d1ec7f
--- /dev/null
+++ b/.run/Template ScalaTest.run.xml	
@@ -0,0 +1,25 @@
+<component name="ProjectRunConfigurationManager">
+    <configuration default="true" type="ScalaTestRunConfiguration" factoryName="ScalaTest" show_console_on_std_err="false" show_console_on_std_out="false">
+        <option name="allowRunningInParallel" value="false" />
+        <option name="projectPathOnTarget" />
+        <option name="selectedOptions">
+            <list />
+        </option>
+        <option name="testKind" value="Regular expression" />
+        <option name="classRegexps">
+            <array>
+                <option value="*Suite" />
+            </array>
+        </option>
+        <option name="javaOptions" value="            --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED            --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.base/sun.nio.ch=ALL-UNNAMED --add-opens=java.base/sun.nio.cs=ALL-UNNAMED --add-opens=java.base/sun.security.action=ALL-UNNAMED --add-opens=java.base/sun.util.calendar=ALL-UNNAMED" />
+        <option name="shortenClasspath" value="NONE" />
+        <option name="testRegexps">
+            <array>
+                <option value="" />
+            </array>
+        </option>
+        <method v="2">
+            <option name="Make" enabled="true" />
+        </method>
+    </configuration>
+</component>
\ No newline at end of file
diff --git a/pom.xml b/pom.xml
index f099574..6cdac4d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -33,15 +33,15 @@
   </developers>
   <properties>
     <gpg.skip>true</gpg.skip>
-    <java.version>11</java.version>
-    <!-- <scala.version>2.12.18</scala.version> -->
+    <java.version>17</java.version>
+    <scala.version>2.12.18</scala.version>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
   </properties>
   <dependencies>
     <dependency>
       <groupId>org.scala-lang</groupId>
       <artifactId>scala-library</artifactId>
-      <version>2.12.18</version>
+      <version>${scala.version}</version>
     </dependency>
     <dependency>
       <groupId>org.apache.spark</groupId>
@@ -96,31 +96,8 @@
       <url>https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/</url>
     </repository>
   </distributionManagement>
-  <!-- <repositories>
-    <repository>
-      <id>scala-tools.org</id>
-      <name>Scala-tools Maven2 Repository</name>
-      <url>http://scala-tools.org/repo-releases</url>
-    </repository>
-  </repositories>
-  <pluginRepositories>
-    <pluginRepository>
-      <id>scala-tools.org</id>
-      <name>Scala-tools Maven2 Repository</name>
-      <url>http://scala-tools.org/repo-releases</url>
-    </pluginRepository>
-  </pluginRepositories> -->
   <build>
     <plugins>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-compiler-plugin</artifactId>
-        <version>3.8.0</version>
-        <configuration>
-          <source>${java.version}</source>
-          <target>${java.version}</target>
-        </configuration>
-      </plugin>
       <plugin>
         <groupId>net.alchim31.maven</groupId>
         <artifactId>scala-maven-plugin</artifactId>
@@ -133,18 +110,16 @@
             </goals>
           </execution>
         </executions>
-        <!-- <configuration>
-          <scalaVersion>${scala.version}</scalaVersion>
-        </configuration>         -->
+        <configuration>
+          <source>${java.version}</source>
+          <target>${java.version}</target>
+        </configuration>
       </plugin>  
       <plugin>
         <groupId>org.scalatest</groupId>
         <artifactId>scalatest-maven-plugin</artifactId>
         <version>2.2.0</version>
         <configuration>
-          <reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory>
-          <junitxml>.</junitxml>
-          <filereports>WDF TestSuite.txt</filereports>
           <argLine>
             --add-opens=java.base/java.lang=ALL-UNNAMED
             --add-opens=java.base/java.lang.invoke=ALL-UNNAMED

From 5cacd227b16f695e63f86e191d2d3f0439ac82f3 Mon Sep 17 00:00:00 2001
From: cccs-br <benoit.roy@cyber.gc.ca>
Date: Fri, 5 Apr 2024 15:11:31 -0400
Subject: [PATCH 3/4] Compile with Java17

---
 .github/workflows/maven.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index daff996..5a6dfab 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -24,7 +24,7 @@ jobs:
     - name: Set up JDK 11
       uses: actions/setup-java@v3
       with:
-        java-version: '11'
+        java-version: '17'
         distribution: 'temurin'
         cache: maven
         server-id: ossrh

From 7d7b8070efc65c9846ba864063ba191a9409ed4e Mon Sep 17 00:00:00 2001
From: cccs-br <benoit.roy@cyber.gc.ca>
Date: Fri, 5 Apr 2024 15:18:02 -0400
Subject: [PATCH 4/4] Fixed git workflow name

---
 .github/workflows/maven.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index 5a6dfab..5e52613 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -21,7 +21,7 @@ jobs:
     
     steps:
     - uses: actions/checkout@v3
-    - name: Set up JDK 11
+    - name: Set up JDK 17
       uses: actions/setup-java@v3
       with:
         java-version: '17'