Skip to content

Commit ebd435e

Browse files
committed
Running a test to see if the favicon still gets rendered.
1 parent 99bf8d1 commit ebd435e

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<meta name="viewport" content="width=360, initial-scale=1.0" />
77
<meta name="theme-color" content="#000000" />
88
<meta name="description" content="Assemblyline 4 React UI" />
9-
<link id="favicon" rel="icon" href="favicon.ico?query=test" />
9+
<link id="favicon" rel="icon" href="favicon.ico" />
1010
<link rel="manifest" href="manifest.json" />
1111
<title>Assemblyline 4</title>
1212
</head>

src/helpers/utils.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ describe('Test `resetFavicon`', () => {
236236
favicon.setAttribute('href', initial);
237237
expect(favicon.getAttribute('href')).toBe(initial);
238238
resetFavicon();
239-
expect(favicon.getAttribute('href')).toBe(`${defaultURL}/favicon.ico?query=test`);
239+
expect(favicon.getAttribute('href')).toBe(`${defaultURL}/favicon.ico`);
240240
});
241241
});
242242

@@ -257,7 +257,7 @@ describe('Test `setNotifyFavicon`', () => {
257257
favicon.setAttribute('href', initial);
258258
expect(favicon.getAttribute('href')).toBe(initial);
259259
setNotifyFavicon();
260-
expect(favicon.getAttribute('href')).toBe(`${defaultURL}/favicon_done.ico?query=test`);
260+
expect(favicon.getAttribute('href')).toBe(`${defaultURL}/favicon_done.ico`);
261261
});
262262
});
263263

src/helpers/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ export function humanReadableNumber(num: number | null) {
131131
export function resetFavicon() {
132132
const favicon: HTMLLinkElement = document.querySelector('#favicon');
133133
// TODO: remove query test
134-
favicon.href = `/favicon.ico?query=test`;
134+
favicon.href = `/favicon.ico`;
135135
}
136136

137137
/**
@@ -144,7 +144,7 @@ export function resetFavicon() {
144144
export function setNotifyFavicon() {
145145
const favicon: HTMLLinkElement = document.querySelector('#favicon');
146146
// TODO: remove query test
147-
favicon.href = `/favicon_done.ico?query=test`;
147+
favicon.href = `/favicon_done.ico`;
148148
}
149149

150150
/**

0 commit comments

Comments
 (0)