Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CX SQL_Injection @ riches/WEB-INF/src/java/com/checkmarx/samples/riches/restful/TransactionResources.java [master] #336

Open
kmcdon83 opened this issue Dec 17, 2019 · 2 comments

Comments

@kmcdon83
Copy link

kmcdon83 commented Dec 17, 2019

SQL_Injection issue exists @ riches/WEB-INF/src/java/com/checkmarx/samples/riches/restful/TransactionResources.java in branch master

The application's IsProfileExist method executes an SQL query with find, at line 241 of riches\WEB-INF\src\java\com\checkmarx\samples\riches\model\ProfileService.java. The application constructs this SQL query by embedding an untrusted string into the query without proper sanitization. The concatenated string is submitted to the database, where it is parsed and executed accordingly.
The attacker would be able to inject arbitrary data into the SQL query, by simply altering the user input username, which is read by the GetTransactions method at line 101 of riches\WEB-INF\src\java\com\checkmarx\samples\riches\restful\TransactionResources.java. This input then flows through the code to the database server, without sanitization.
This may enable an SQL Injection attack.

Severity: High

CWE:89

Vulnerability details and guidance

Internal Guidance

Checkmarx

Lines: 102 104 105 106 107

Lines Marked Not Exploitable: 101


Code (Line #102):

                           @PathParam("acctno") @DefaultValue("0422328325") String acctno,

Code (Line #104):

                           @MatrixParam("payee") String payee,

Code (Line #105):

                           @MatrixParam("amount") String amount,

Code (Line #106):

                           @QueryParam("memo") String memo,

Code (Line #107):

                           @QueryParam("id") String id){

@kmcdon83
Copy link
Author

Issue still exists.

1 similar comment
@kmcdon83
Copy link
Author

Issue still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant