Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working shooter #137

Conversation

totallysomeoneyoudontknow
Copy link
Contributor

What this PR does

What does it fix/add?
Reference issues with "Fixes #10" or "Closes #10", where #10 is the number assigned to the issue

What does this depend on?
References pull requests or branches/forks that this pull request depends on

@spacey-sooty
Copy link
Member

/format

Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a merge

Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stop the formatter from exiting early


class Shooter : public behaviour::HasBehaviour{
public:
Shooter(ShooterConfig config);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be marked explicit

#pragma once
#include "Wombat.h"
#include <units/angular_velocity.h>
#include <frc/DigitalInput.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add #include

if (_pid.IsStable()) {
SetState(ShooterState::kShooting);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this newline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pathplanner
3 participants