Skip to content

Commit 54c5df1

Browse files
committed
Bump AWS-LC dependency to 1.45 (#431)
AWS-LC [PR #2157](aws/aws-lc#2157) newly supports parsing ML-DSA private keys from seeds, as BouncyCastle does, so we update our relevant interop test.
1 parent 767f348 commit 54c5df1

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

aws-lc

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ plugins {
1414

1515
group = 'software.amazon.cryptools'
1616
version = '2.5.0'
17-
ext.awsLcMainTag = 'v1.44.0'
17+
ext.awsLcMainTag = 'v1.45.0'
1818
ext.awsLcFipsTag = 'AWS-LC-FIPS-3.0.0'
1919
ext.isExperimentalFips = Boolean.getBoolean('EXPERIMENTAL_FIPS')
2020
ext.isFips = ext.isExperimentalFips || Boolean.getBoolean('FIPS')

tst/com/amazon/corretto/crypto/provider/test/MLDSATest.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -236,21 +236,11 @@ public void documentBouncyCastleDifferences() throws Exception {
236236
assertThrows(
237237
InvalidKeyException.class, () -> bcSignature.initSign(finalNativePair.getPrivate()));
238238

239-
// ACCP can't use BouncyCastle private keys due to seed/expanded encoding difference
240-
Signature finalNativeSignature = Signature.getInstance("ML-DSA", NATIVE_PROVIDER);
241-
final KeyPair finalBcPair = bcPair;
242-
assertThrows(
243-
InvalidKeyException.class, () -> finalNativeSignature.initSign(finalBcPair.getPrivate()));
244-
245-
// However, ACCP can use BouncyCastle public keys
239+
// However, ACCP can use BouncyCastle KeyPairs with seed-encoded PrivateKeys
246240
Signature nativeSignature = Signature.getInstance("ML-DSA", NATIVE_PROVIDER);
247-
nativeSignature.initSign(nativePair.getPrivate());
241+
nativeSignature.initSign(bcPair.getPrivate());
248242
byte[] sigBytes = nativeSignature.sign();
249-
assertNotNull(sigBytes);
250-
PublicKey bcPub =
251-
KeyFactory.getInstance("ML-DSA", TestUtil.BC_PROVIDER)
252-
.generatePublic(new X509EncodedKeySpec(nativePair.getPublic().getEncoded()));
253-
nativeSignature.initVerify(bcPub);
243+
nativeSignature.initVerify(bcPair.getPublic());
254244
assertTrue(nativeSignature.verify(sigBytes));
255245
}
256246

0 commit comments

Comments
 (0)