Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use in CI Systems #4

Open
CryogenicPlanet opened this issue Nov 4, 2021 · 1 comment
Open

Use in CI Systems #4

CryogenicPlanet opened this issue Nov 4, 2021 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@CryogenicPlanet
Copy link
Owner

As this is likely not a one-time problem, it would be good to be able to integrate this as a part of your CI pipeline.

Thoughts:

  • The tool can wrongly target a package as being unused, this might be because we don't actually see the package in the code. Think apollo or graphql or the tool is making a mistake.

  • We can partially mitigate the above, by allowing users to configure accepted packages or ignored packages in Configuration Files #3 so we can check against those

  • This likely should be used as a fail condition on CI systems but rather something like codecov or something, it can generate the report and add it as a PR comment
@CryogenicPlanet CryogenicPlanet added the enhancement New feature or request label Nov 4, 2021
This was referenced Nov 4, 2021
Closed
Merged
@CryogenicPlanet CryogenicPlanet added the bug Something isn't working label Nov 8, 2021
@CryogenicPlanet
Copy link
Owner Author

There is a bug where the module does not work correctly in CI systems and causes issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CryogenicPlanet