Skip to content

Commit 8b8e16b

Browse files
committed
Merge branch 'refs/heads/3.3' into feat/remove_test3
2 parents b2614f2 + 21f5e1d commit 8b8e16b

File tree

11 files changed

+24
-201
lines changed

11 files changed

+24
-201
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
66
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
77
- [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
8-
- [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](./CONTRIBUTING.md)
8+
- [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md)

dubbo-cluster/pom.xml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,6 @@
4747
<version>${project.parent.version}</version>
4848
<scope>test</scope>
4949
</dependency>
50-
<dependency>
51-
<groupId>org.apache.curator</groupId>
52-
<artifactId>curator-framework</artifactId>
53-
<scope>test</scope>
54-
</dependency>
55-
<dependency>
56-
<groupId>org.apache.zookeeper</groupId>
57-
<artifactId>zookeeper</artifactId>
58-
<scope>test</scope>
59-
</dependency>
6050
<dependency>
6151
<groupId>org.apache.dubbo</groupId>
6252
<artifactId>dubbo-serialization-hessian2</artifactId>
@@ -69,12 +59,6 @@
6959
<version>${project.parent.version}</version>
7060
<scope>test</scope>
7161
</dependency>
72-
<dependency>
73-
<groupId>org.apache.dubbo</groupId>
74-
<artifactId>dubbo-test-check</artifactId>
75-
<version>${project.parent.version}</version>
76-
<scope>test</scope>
77-
</dependency>
7862
<dependency>
7963
<groupId>org.apache.dubbo</groupId>
8064
<artifactId>dubbo-metrics-registry</artifactId>

dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/router/ConfigConditionRouterTest.java

Lines changed: 0 additions & 129 deletions
This file was deleted.

dubbo-config/dubbo-config-api/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@
237237
<dependency>
238238
<groupId>org.testcontainers</groupId>
239239
<artifactId>testcontainers</artifactId>
240-
<version>1.20.3</version>
240+
<version>1.20.4</version>
241241
<scope>test</scope>
242242
</dependency>
243243

dubbo-configcenter/dubbo-configcenter-zookeeper/pom.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,6 @@
4040
<version>${project.parent.version}</version>
4141
</dependency>
4242

43-
<dependency>
44-
<groupId>org.apache.dubbo</groupId>
45-
<artifactId>dubbo-test-common</artifactId>
46-
<version>${project.parent.version}</version>
47-
<scope>test</scope>
48-
</dependency>
49-
5043
<dependency>
5144
<groupId>org.apache.curator</groupId>
5245
<artifactId>curator-framework</artifactId>

dubbo-configcenter/pom.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,4 @@
3838
<skip_maven_deploy>false</skip_maven_deploy>
3939
</properties>
4040

41-
<dependencies>
42-
<dependency>
43-
<groupId>org.apache.dubbo</groupId>
44-
<artifactId>dubbo-test-check</artifactId>
45-
<version>${project.parent.version}</version>
46-
<scope>test</scope>
47-
</dependency>
48-
</dependencies>
4941
</project>

dubbo-dependencies-bom/pom.xml

Lines changed: 4 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
<!-- <spring_version>4.3.30.RELEASE</spring_version> -->
9292
<spring_version>5.3.39</spring_version>
9393
<spring_boot_version>2.7.18</spring_boot_version>
94-
<spring_security_version>5.8.15</spring_security_version>
94+
<spring_security_version>5.8.16</spring_security_version>
9595
<javassist_version>3.30.2-GA</javassist_version>
9696
<byte-buddy_version>1.15.10</byte-buddy_version>
9797
<netty_version>3.2.10.Final</netty_version>
@@ -104,7 +104,6 @@
104104
<zookeeper_version>3.7.2</zookeeper_version>
105105
<curator_version>5.7.1</curator_version>
106106
<curator_test_version>2.12.0</curator_test_version>
107-
<jedis_version>3.10.0</jedis_version>
108107
<hessian_version>4.0.66</hessian_version>
109108
<protobuf-java_version>3.25.5</protobuf-java_version>
110109
<javax_annotation-api_version>1.3.2</javax_annotation-api_version>
@@ -150,8 +149,8 @@
150149
<log4j_version>1.2.17</log4j_version>
151150
<logback_version>1.2.13</logback_version>
152151
<!-- Fix the bug of log4j refer:https://github.com/apache/logging-log4j2/pull/608 -->
153-
<log4j2_version>2.24.1</log4j2_version>
154-
<commons_io_version>2.17.0</commons_io_version>
152+
<log4j2_version>2.24.2</log4j2_version>
153+
<commons_io_version>2.18.0</commons_io_version>
155154
<commons-codec_version>1.17.1</commons-codec_version>
156155
<groovy_version>4.0.24</groovy_version>
157156

@@ -161,19 +160,17 @@
161160
<awaitility_version>4.2.2</awaitility_version>
162161
<hamcrest_version>2.2</hamcrest_version>
163162
<cglib_version>2.2.2</cglib_version>
164-
<embedded_redis_version>1.4.3</embedded_redis_version>
165163
<mockito_version>4.11.0</mockito_version>
166164
<spock_version>2.3-groovy-4.0</spock_version>
167165

168166
<jaxb_version>2.2.7</jaxb_version>
169167
<activation_version>1.2.0</activation_version>
170-
<test_container_version>1.20.3</test_container_version>
168+
<test_container_version>1.20.4</test_container_version>
171169
<hessian_lite_version>4.0.3</hessian_lite_version>
172170
<swagger_version>1.6.14</swagger_version>
173171

174172
<snappy_java_version>1.1.10.7</snappy_java_version>
175173
<bouncycastle-bcprov_version>1.70</bouncycastle-bcprov_version>
176-
<sofa_registry_version>5.4.3</sofa_registry_version>
177174
<metrics_version>2.0.6</metrics_version>
178175
<gson_version>2.11.0</gson_version>
179176
<jackson_version>2.18.1</jackson_version>
@@ -185,7 +182,6 @@
185182
<spotless.action>check</spotless.action>
186183
<dubbo-shared-resources.version>1.0.0</dubbo-shared-resources.version>
187184
<palantirJavaFormat.version>2.38.0</palantirJavaFormat.version>
188-
<open_feign_version>3.1.9</open_feign_version>
189185
<jakarta.xml.bind-api.version>4.0.2</jakarta.xml.bind-api.version>
190186
<jaxb-runtime.version>2.4.0-b180830.0438</jaxb-runtime.version>
191187
<!-- Spring boot buddy is lower than the delivery dependency package version and can only show the defined dependency version -->
@@ -400,11 +396,6 @@
400396
</exclusion>
401397
</exclusions>
402398
</dependency>
403-
<dependency>
404-
<groupId>redis.clients</groupId>
405-
<artifactId>jedis</artifactId>
406-
<version>${jedis_version}</version>
407-
</dependency>
408399

409400
<!-- Alibaba -->
410401

@@ -724,19 +715,6 @@
724715
<version>${swagger_version}</version>
725716
</dependency>
726717

727-
<!-- for dubbo-registry-sofa -->
728-
<dependency>
729-
<groupId>com.alipay.sofa</groupId>
730-
<artifactId>registry-client-all</artifactId>
731-
<version>${sofa_registry_version}</version>
732-
</dependency>
733-
<dependency>
734-
<groupId>com.alipay.sofa</groupId>
735-
<artifactId>registry-test</artifactId>
736-
<version>${sofa_registry_version}</version>
737-
<scope>test</scope>
738-
</dependency>
739-
740718
<!-- Test libs -->
741719
<dependency>
742720
<groupId>org.junit.jupiter</groupId>
@@ -804,12 +782,6 @@
804782
<version>${cglib_version}</version>
805783
<scope>test</scope>
806784
</dependency>
807-
<dependency>
808-
<groupId>com.github.codemonstur</groupId>
809-
<artifactId>embedded-redis</artifactId>
810-
<version>${embedded_redis_version}</version>
811-
<scope>test</scope>
812-
</dependency>
813785
<dependency>
814786
<groupId>org.springframework</groupId>
815787
<artifactId>spring-test</artifactId>
@@ -998,11 +970,6 @@
998970
<artifactId>rxjava</artifactId>
999971
<version>${rxjava.version}</version>
1000972
</dependency>
1001-
<dependency>
1002-
<groupId>org.springframework.cloud</groupId>
1003-
<artifactId>spring-cloud-openfeign-core</artifactId>
1004-
<version>${open_feign_version}</version>
1005-
</dependency>
1006973
<dependency>
1007974
<groupId>jakarta.xml.bind</groupId>
1008975
<artifactId>jakarta.xml.bind-api</artifactId>

dubbo-maven-plugin/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
<dependency>
7676
<groupId>commons-io</groupId>
7777
<artifactId>commons-io</artifactId>
78-
<version>2.17.0</version>
78+
<version>2.18.0</version>
7979
</dependency>
8080

8181
<!-- Takes no effect for this dependency. To notify github dependencies bot to update ${protobuf-java.version} property. -->

dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/rest/mapping/DefaultRequestMappingRegistry.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,7 @@ public void unregister(Invoker<?> invoker) {
180180
if (tree == null) {
181181
return;
182182
}
183+
183184
lock.writeLock().lock();
184185
try {
185186
tree.remove(mapping -> mapping.meta.getInvoker() == invoker);
@@ -193,6 +194,7 @@ public void destroy() {
193194
if (tree == null) {
194195
return;
195196
}
197+
196198
lock.writeLock().lock();
197199
try {
198200
tree.clear();
@@ -202,6 +204,10 @@ public void destroy() {
202204
}
203205

204206
public HandlerMeta lookup(HttpRequest request) {
207+
if (tree == null) {
208+
return null;
209+
}
210+
205211
String stringPath = PathUtils.normalize(request.uri());
206212
request.setAttribute(RestConstants.PATH_ATTRIBUTE, stringPath);
207213
KeyString path = new KeyString(stringPath, restConfig.getCaseSensitiveMatchOrDefault());
@@ -365,6 +371,10 @@ private void handleNoMatch(HttpRequest request, List<RequestMapping> partialMatc
365371

366372
@Override
367373
public boolean exists(String stringPath, String method) {
374+
if (tree == null) {
375+
return false;
376+
}
377+
368378
KeyString path = new KeyString(stringPath, restConfig.getCaseSensitiveMatchOrDefault());
369379
if (tryExists(path, method)) {
370380
return true;

dubbo-spring-boot-project/dubbo-spring-boot/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,12 @@
5252
<version>${project.version}</version>
5353
<optional>true</optional>
5454
</dependency>
55+
<dependency>
56+
<groupId>org.apache.dubbo</groupId>
57+
<artifactId>dubbo-config-spring</artifactId>
58+
<version>${project.version}</version>
59+
<optional>true</optional>
60+
</dependency>
5561

5662
<!-- Test Dependencies -->
5763
<dependency>

0 commit comments

Comments
 (0)