Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] move ISR to IRAM #8

Closed
wants to merge 1 commit into from
Closed

[BUGFIX] move ISR to IRAM #8

wants to merge 1 commit into from

Conversation

foertel
Copy link

@foertel foertel commented Nov 8, 2022

Fixes #7

@CrashOverride85
Copy link
Owner

Thanks for this 🙂
I've tested it and it works well on an ESP32 (and I assume ESP8266), but it's no longer building for Arduino Uno / AVR as IRAM_ATTR is unknown ("error: ‘IRAM_ATTR’ does not name a type").

I think it could be fixed by adding something like this to collar.h, just after the #include "Arduino.h" line:

#ifndef ARDUINO_ARCH_ESP8266
  #define IRAM_ATTR
#endif

#ifndef ARDUINO_ARCH_ESP32
  #define IRAM_ATTR
#endif

@foertel foertel closed this by deleting the head repository Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ISR is supposed to be in IRAM for esp8266
2 participants
@foertel @CrashOverride85