Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Role Assignment Overwrites Instead of Concatenates #55

Open
starempire opened this issue Jun 16, 2021 · 0 comments
Open

Testing Role Assignment Overwrites Instead of Concatenates #55

starempire opened this issue Jun 16, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@starempire
Copy link

Is your feature request related to a problem? Please describe.

Calling member.add_roles(role) while using an iterable (ex: member.add_roles(*[role1, role2])) replaces the member's role property with the last role called. Calling the above for example leaves the member with the @everyone role and role2.

Describe the solution you'd like

Calling member.add_roles only appends new roles to an existing role list. In the above example, role 1 and 2 both exist on user. Calling member.add_roles(*[role3, role4]) next should result in a member having roles 1, 2, 3, 4, and the default @everyone role. In current implementation, the member ends up with only role4 in this example, plus @everyone.

Describe alternatives you've considered

n/a

Additional context

n/a

@CraftSpider CraftSpider added the bug Something isn't working label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants