Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow propagation #82

Open
ViieeS opened this issue Oct 29, 2018 · 5 comments
Open

Allow propagation #82

ViieeS opened this issue Oct 29, 2018 · 5 comments

Comments

@ViieeS
Copy link
Contributor

ViieeS commented Oct 29, 2018

I try to use uiCropper and ui.bootstrap.contextMenu together.

<div context-menu="$ctrl.contextMenu">
        <ui-cropper
                image="$ctrl.image"
                result-image-format="image/jpeg"
                area-type="rectangle"
                init-max-area="true"
        ></ui-cropper>
</div>

The problem is after menu opened it doesn't close with left or right click because of this line:

e.stopPropagation();

@CrackerakiUA, can you please explain why we use it here? Maybe we can allow event propagation optionally?

@CrackerakiUA
Copy link
Owner

we need it there, try to handle bootstrap click above ui-cropper

@CrackerakiUA
Copy link
Owner

if you can't handle, you can add option to disable it, so by default it should be enabled. PR are welcome, just update also docs

ViieeS pushed a commit to ViieeS/ui-cropper that referenced this issue Nov 2, 2018
Optional. A boolean determining whether to allow 'mousedown' event propagation.

CrackerakiUA#82
@ViieeS
Copy link
Contributor Author

ViieeS commented Nov 2, 2018

@CrackerakiUA I've created PR, but I didn't get where to update the docs. I've added description to PR.

@CrackerakiUA
Copy link
Owner

@ViieeS
Copy link
Contributor Author

ViieeS commented Nov 3, 2018

@CrackerakiUA actually it's not clear for me how to create PR on the wiki. I've create a new repo and made changes here: https://github.com/ViieeS/ui-cropper-wiki.

Also, please make npm publish the latest version of ui-cropper. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants