Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Purge OTC only after first upload by a keypair #5

Open
burke opened this issue May 19, 2020 · 0 comments
Open

Idea: Purge OTC only after first upload by a keypair #5

burke opened this issue May 19, 2020 · 0 comments

Comments

@burke
Copy link
Member

burke commented May 19, 2020

Currently we purge one-time-codes as soon as the KeyClaimRequest is processed, which means that if the KeyClaimResponse is lost, the user will need to ask their HCP for a new code.

In order to mitigate this, we should consider purging the OTC only as the first upload is being recorded, so that KeyClaimRequest can be idempotent if the same keypair and OTC is received again as a duplicate request before the first upload.

(thanks @dylanahsmith for pointing this out)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant