Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement : Highlight.php ? #262

Open
ncou opened this issue Dec 23, 2020 · 2 comments
Open

improvement : Highlight.php ? #262

ncou opened this issue Dec 23, 2020 · 2 comments

Comments

@ncou
Copy link

ncou commented Dec 23, 2020

Hi,

Nice piece of code. I have just tested this tool but it seems to do the work. Simple and powerfull.

Just my 2 cents opinion, I think using the highlighter "https://github.com/scrivo/highlight.php" could be a fine plugin to Couscous, the idea is that most of the site using coucous should also use an highlighter (mostly in javascript to apply the highlight on the fly) so a plugin to enable the highlight during the conversion of markdow to html file could be a plus. And the user could simply add the highlight.js CSS file.

What do you think ?

@mnapoli
Copy link
Member

mnapoli commented Jan 15, 2021

Why not, but I'm afraid this would add some complexity and some more dependencies for something that can be solved in JS.

@ncou
Copy link
Author

ncou commented Jan 15, 2021

Yes it could add some complexity, and the JS way work fine. I just find the result a bit slow while doing the highlighting on-the-fly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants