Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference-style links to .md files aren't resolved to the generated url #155

Open
Firehed opened this issue Apr 2, 2016 · 2 comments
Open
Labels

Comments

@Firehed
Copy link
Contributor

Firehed commented Apr 2, 2016

Using a reference-style link fails to automatically convert a markdown file url to its html counterpart, which is inconsistent with the documentation indicating that links should work between pages.

That is to say:

Using [a link](foo.md) to [a page][bar] or [baz][]

[bar]: bar.md
[baz]: baz.md

renders

Using <a href="foo.html">a link</a> to
<a href="bar.md">a page</a> or <a
href="baz.md">baz</a>

instead of

Using <a href="foo.html">a link</a> to
<a href="bar.html">a page</a> or <a
href="baz.html">baz</a>

In practice it's not really a huge issue, but it's not quite what you would expect to happen.

@mnapoli mnapoli added the bug label Apr 3, 2016
@mnapoli
Copy link
Member

mnapoli commented Apr 3, 2016

Right, I'm guessing that this class only rewrites classic links and not reference-style links. I'm guessing #134 (i.e. replace Parsedown with CommonMark) would help since we could get rid of the regex and directly edit the AST that was generated from the markdown source. But for that we need to have a CommonMark extension for Markdown Extra, because currently that's a feature offered by Couscous.

@mnapoli
Copy link
Member

mnapoli commented Apr 3, 2016

On the "CommonkMark" topic I've opened #156.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants