fix/type-errors (#159)

* Fix type errors for event page

* Format changes

* Fix type error for person page

* Add `typeCheck` to build cmd

Author: tohuynh

package.json

@@ -23,7 +23,7 @@
     "deploy:app": "gh-pages -d build",
     "preview:app": "vite preview -c vite.app.config.js --base /cdp-frontend/",
     "build:lib": "vite build -c vite.lib.config.js",
-    "build": "npm-run-all --print-label clean --parallel build:app build:lib generateTypes",
+    "build": "npm-run-all --print-label clean --parallel typeCheck build:app build:lib generateTypes",
     "clean": "rimraf build dist type-declarations",
     "format": "prettier --write src/**/*",
     "checkFormat": "prettier --check src/**/*.tsx",

src/components/Details/EventVideo/EventVideo.stories.tsx

@@ -14,5 +14,5 @@ export const eventVideo = Template.bind({});
 eventVideo.args = {
   uri: "https://video.seattle.gov/media/council/council_113020_2022091V.mp4",
   componentRef: createRef<EventVideoRef>(),
-  sessionNum: 0,
+  sessionIndex: 0,
 };

src/components/Details/TranscriptFull/TranscriptFull.tsx

@@ -4,7 +4,7 @@ import styled from "@emotion/styled";
 
 import TranscriptItem, { TranscriptItemRef } from "../TranscriptItem/TranscriptItem";
 
-import { SentenceWithSessionIndex } from "../../../containers/EventContainer/types";
+import { ECSentence } from "../../../containers/EventContainer/types";
 import secondsToHHMMSS from "../../../utils/secondsToHHMMSS";
 
 const TranscripItems = styled.div({
@@ -14,7 +14,7 @@ const TranscripItems = styled.div({
 
 export interface TranscriptFullProps {
   /**The sentences of the transcript */
-  sentences: SentenceWithSessionIndex[];
+  sentences: ECSentence[];
   /**List of transcript item React references */
   transcriptItemsRefs: RefObject<TranscriptItemRef>[];
   /**Callback to play video clip */

src/components/Details/TranscriptItem/TranscriptItem.stories.tsx

@@ -17,8 +17,7 @@ withPictureSrc.args = {
   sessionIndex: 0,
   speakerId: "speaker-id-1",
   speakerName: "Lisa Herbold",
-  text:
-    "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
+  text: "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
   startTime: "05:00:45",
   speakerPictureSrc: "https://www.seattle.gov/images/Council/Members/Herbold/Herbold_225x225.jpg",
   handleJumpToTranscript: action("handleJumpToTranscript"),
@@ -29,8 +28,7 @@ withoutPictureSrc.args = {
   sessionIndex: 0,
   speakerId: "speaker-id-1",
   speakerName: "Lisa Herbold",
-  text:
-    "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
+  text: "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
   startTime: "05:00:45",
   handleJumpToTranscript: action("handleJumpToTranscript"),
 };
@@ -40,8 +38,7 @@ withSearchQuery.args = {
   sessionIndex: 0,
   speakerId: "speaker-id-1",
   speakerName: "Lisa Herbold",
-  text:
-    "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
+  text: "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
   startTime: "05:00:45",
   speakerPictureSrc: "https://www.seattle.gov/images/Council/Members/Herbold/Herbold_225x225.jpg",
   searchQuery: "ipsum dolor sit",

src/components/Details/TranscriptSearch/TranscriptItems.tsx

@@ -11,11 +11,11 @@ import {
 import { TranscriptItem } from "../TranscriptItem";
 
 import secondsToHHMMSS from "../../../utils/secondsToHHMMSS";
-import { SentenceWithSessionIndex } from "../../../containers/EventContainer/types";
+import { ECSentence } from "../../../containers/EventContainer/types";
 
 interface TranscriptItemsProps {
   searchQuery: string;
-  sentences: SentenceWithSessionIndex[];
+  sentences: ECSentence[];
   jumpToVideoClip(sessionIndex: number, startTime: number): void;
   jumpToTranscript(sentenceIndex: number): void;
 }

src/components/Details/TranscriptSearch/TranscriptSearch.tsx

@@ -4,7 +4,7 @@ import { stem } from "stemr";
 import { removeStopwords } from "stopword";
 
 import TranscriptItems from "./TranscriptItems";
-import { SentenceWithSessionIndex } from "../../../containers/EventContainer/types";
+import { ECSentence } from "../../../containers/EventContainer/types";
 
 import { strings } from "../../../assets/LocalizedStrings";
 import { fontSizes } from "../../../styles/fonts";
@@ -51,7 +51,7 @@ export interface TranscriptSearchProps {
   /**The search query */
   searchQuery: string;
   /**The sentences of the transcript */
-  sentences?: SentenceWithSessionIndex[];
+  sentences?: ECSentence[];
   /**Callback to play video clip */
   jumpToVideoClip(sessionIndex: number, startTime: number): void;
   /**Callback to jump to sentence in the full transcript component */

src/components/Filters/SelectTextFilterOptions/getCheckboxText.ts

@@ -9,8 +9,9 @@ import { FilterState } from "../reducer";
  * @returns {string} The text representation.
  */
 const getCheckboxText = (checkboxes: FilterState<boolean>, defaultText: string): string => {
-  const numberOfSelectedCheckbox = Object.values(checkboxes).filter((dataValue) => dataValue)
-    .length;
+  const numberOfSelectedCheckbox = Object.values(checkboxes).filter(
+    (dataValue) => dataValue
+  ).length;
   const textRep = numberOfSelectedCheckbox
     ? `${defaultText} : ${numberOfSelectedCheckbox}`
     : defaultText;

src/components/Filters/reducer.ts

@@ -14,22 +14,21 @@ export interface FilterAction<T> {
 }
 
 /**Create a filterReducer to manage filter's state.*/
-const createFilterReducer = <T>() => (
-  state: FilterState<T>,
-  action: FilterAction<T>
-): FilterState<T> => {
-  switch (action.type) {
-    case FILTER_UPDATE:
-      return { ...state, [action.payload.keyName as string]: action.payload.dataValue as T };
-    case FILTER_CLEAR:
-      const newState = { ...state };
-      Object.keys(newState).forEach(
-        (keyName) => (newState[keyName] = action.payload.dataValue as T)
-      );
-      return newState;
-    default:
-      return state;
-  }
-};
+const createFilterReducer =
+  <T>() =>
+  (state: FilterState<T>, action: FilterAction<T>): FilterState<T> => {
+    switch (action.type) {
+      case FILTER_UPDATE:
+        return { ...state, [action.payload.keyName as string]: action.payload.dataValue as T };
+      case FILTER_CLEAR:
+        const newState = { ...state };
+        Object.keys(newState).forEach(
+          (keyName) => (newState[keyName] = action.payload.dataValue as T)
+        );
+        return newState;
+      default:
+        return state;
+    }
+  };
 
 export default createFilterReducer;

src/components/Layout/TabbedContainer/TabbedContainer.stories.tsx

@@ -12,7 +12,7 @@ const Template: Story<TabbedContainerProps> = (args) => <TabbedContainer {...arg
 
 export const tabbedContainer = Template.bind({});
 tabbedContainer.args = {
-  tabLabels: (["Minutes and Documents", "Full Transcript", "Votes"] as unknown) as JSX.Element[],
+  tabLabels: ["Minutes and Documents", "Full Transcript", "Votes"] as unknown as JSX.Element[],
   children: [
     <p key={1}>Contents of Page 1</p>,
     <p key={2}>Contents of Page 2</p>,

src/containers/EventContainer/EventContainer.stories.tsx

@@ -4,7 +4,7 @@ import { Story, Meta } from "@storybook/react";
 import EventContainer, { EventContainerProps } from "./EventContainer";
 
 import { MATTER_STATUS_DECISION, VOTE_DECISION } from "../../constants/ProjectConstants";
-import { SentenceWithSessionIndex } from "./types";
+import { ECSentence } from "./types";
 
 export default {
   component: EventContainer,
@@ -13,7 +13,7 @@ export default {
 
 const Template: Story<EventContainerProps> = (args) => <EventContainer {...args} />;
 
-const sentences: SentenceWithSessionIndex[] = [];
+const sentences: ECSentence[] = [];
 for (let sessionIndex = 0; sessionIndex < 2; sessionIndex++) {
   for (let sentenceIndex = 0; sentenceIndex < 10; sentenceIndex++) {
     sentences.push({
@@ -37,24 +37,25 @@ event.args = {
   },
   sessions: [
     {
+      id: "s1",
       video_uri: "https://video.seattle.gov/media/council/council_113020_2022091V.mp4",
       session_index: 1,
-      session_datetime: new Date(0),
     },
     {
+      id: "s2",
       video_uri: "https://video.seattle.gov/media/council/econ_090821_2602120V.mp4",
       session_index: 2,
-      session_datetime: new Date(3600000),
     },
   ],
   sentences: sentences,
   eventMinutesItems: [
     {
+      id: "test1",
       minutes_item: { name: "test" },
     },
     {
       id: "test2",
-      minutes_item: { name: "test2", description: "test desc", matter: { id: "matter-id" } },
+      minutes_item: { name: "test2", description: "test desc", matter_ref: "matter-id" },
       decision: MATTER_STATUS_DECISION.REJECTED,
       files: [
         {