Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing LF character is added when content files are zipped #29

Closed
nabeta opened this issue Aug 4, 2020 · 0 comments · Fixed by #30
Closed

Trailing LF character is added when content files are zipped #29

nabeta opened this issue Aug 4, 2020 · 0 comments · Fixed by #30

Comments

@nabeta
Copy link
Contributor

nabeta commented Aug 4, 2020

I noticed willow_sword adds a trailing LF character to content files when it creates a zip file. The following is an example to create a zip file for public directory in a Rails project.

$ rails c
> file = WillowSword::ZipPackage.new('public', 'data/test.zip')
> file.create_zip
$ unzip test.zip -d tmp
$ diff -u tmp/apple-touch-icon.png hyrax/public/apple-touch-icon.png
Binary files tmp/apple-touch-icon.png and hyrax/public/apple-touch-icon.png differ
$ cmp tmp/apple-touch-icon.png hyrax/public/apple-touch-icon.png
cmp: EOF on hyrax/public/apple-touch-icon.png after byte 5401, in line 26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant