[shell] format & optimized

Author: ucwong

start.sh

@@ -1,35 +1,46 @@
 #!/bin/bash
-set +m
+#set +m
 cvm_pid=cvm.pid
 node_pid=node.pid
-tracker_pid=tracker_pid
+#tracker_pid=tracker_pid
 remove=1
 trap 'EXIT' INT
 function EXIT(){
 	if [ $remove -eq 0 ];then
 		exit 0
 	fi
-	pkill -P `cat cvm.pid`
-	wait $!
+
+	if [ -f ${cvm_pid} ];then
+		pkill -P `cat ${cvm_pid}`
+		wait $!
+		echo "INFO [$(date +"%d-%m|%H:%M:%S:000")] Cortex virtual machine exited with status $?."
+	else
+		echo "INFO [$(date +"%d-%m|%H:%M:%S:000")] Cortex virtual machine pid file not exist. Try to stop process manually."
+	fi
 	#echo "cvm stopped successfully"
-	echo "INFO [$(date +"%d-%m|%H:%M:%S:000")] Cortex virtual machine exited with status $?."
+	#echo "INFO [$(date +"%d-%m|%H:%M:%S:000")] Cortex virtual machine exited with status $?."
 	#wait `cat cvm.pid` 2>/dev/null
 	#ps aux | grep 'cortex cvm' | grep -v grep | grep -v echo | cut -c 9-15 | xargs kill -9
 #	pkill -P `cat tracker.pid`
-	pkill -P `cat node.pid`
-	wait $!
+	if [ -f ${node_pid} ];then
+		pkill -P `cat ${node_pid}`
+		wait $!
+		echo "INFO [$(date +"%d-%m|%H:%M:%S:000")] Cortex full node exited with status $?."
+	else
+		echo "INFO [$(date +"%d-%m|%H:%M:%S:000")] Cortex full node pid file not exist. Try to stop process manually."
+	fi
         #echo "cortex node stopped successfully"
-	echo "INFO [$(date +"%d-%m|%H:%M:%S:000")] Cortex full node exited with status $?."
-	rm -rf cvm.pid node.pid
+	#echo "INFO [$(date +"%d-%m|%H:%M:%S:000")] Cortex full node exited with status $?."
+	rm -rf ${cvm_pid} ${node_pid}
 	wait $!
 	echo "INFO [$(date +"%d-%m|%H:%M:%S:000")] Cortex workspace cleaned with status $?."
 	#echo "clean [$cvm_pid, $node_pid]"
 	#	ps aux | grep 'bittorrent-tracker' | grep -v grep | grep -v echo | cut -c 9-15 | xargs kill -9
 	exit 0
 }
 
-if [ -f $cvm_pid ];then
-	echo "cvm is running with pid [`cat cvm.pid`]. You should stop this process first."
+if [ -f ${cvm_pid} ];then
+	echo "cvm is running with pid [`cat ${cvm_pid}`]. You should stop this process first."
 	remove=0
 	exit 0
 fi
@@ -40,8 +51,8 @@ fi
 #        exit 0
 #fi
 
-if [ -f $node_pid ];then
-        echo "cortex node is running with pid [`cat node.pid`]. You should stop this process first."
+if [ -f ${node_pid} ];then
+        echo "cortex node is running with pid [`cat ${node_pid}`]. You should stop this process first."
 	remove=0
         exit 0
 fi
@@ -50,12 +61,14 @@ function start_cvm(){
 	#./cvm.sh | grep -v 'Terminated   ' & #>/dev/null 2>&1 &
 	#echo $$ > cvm.pid
 	./cvm.sh 2>/dev/null &
-	echo $! > cvm.pid
+	echo $! > ${cvm_pid}
+	chmod 644 "${cvm_pid}"
 }
 
 function start_node(){
 	./node.sh &
-	echo $! > node.pid
+	echo $! > ${node_pid}
+	chmod 644 "${node_pid}"
 }
 
 #function start_tracker(){
@@ -71,7 +84,7 @@ start_cvm
 start_node
 while true; do
         server=`ps aux | grep 'cortex cvm' | grep -v grep | grep -v echo`
-        if [ ! "$server" ]; then
+        if [ ! "${server}" ]; then
             #./cvm.sh &
 	    #echo $! > cvm.pid
 	    start_cvm

stop_tracker.sh

@@ -1,11 +1,11 @@
 #!/bin/bash
 tracker_pid=tracker.pid
-if [ ! -f $tracker_pid ];then
+if [ ! -f ${tracker_pid} ];then
         echo "INFO [$(date +"%d-%m|%H:%M:%S:000")] Cortex tracker is not running."
         exit 0
 fi
-pkill -P `cat tracker.pid`
+pkill -P `cat ${tracker_pid}`
 wait $!
 echo "INFO [$(date +"%d-%m|%H:%M:%S:000")] Cortex tracker exited with status $?."
-rm -rf tracker.pid
+rm -rf ${tracker_pid}
 echo "INFO [$(date +"%d-%m|%H:%M:%S:000")] Cortex workspace cleaned with status $?."

tracker.sh

@@ -1,8 +1,8 @@
 #!/bin/bash
 tracker_pid=tracker.pid
-if [ -f $tracker_pid ];then
+if [ -f ${tracker_pid} ];then
         echo "tracker is running."
         exit 0
 fi
 ./build/bin/tracker > /dev/null 2>&1 &
-echo $! > tracker.pid
+echo $! > ${tracker_pid}