Merge pull request #1998 from CortexFoundation/dev

ucwong · web-flow · commit 88d852abb67d · 2024-04-30T09:37:27.000+01:00
build: fix string compare for SortFunc
diff --git a/build/update-license.go b/build/update-license.go
@@ -291,8 +291,8 @@ func writeAuthors(files []string) {
 		}
 	}
 	// Write sorted list of authors back to the file.
-	slices.SortFunc(list, func(a, b string) bool {
-		return strings.ToLower(a) < strings.ToLower(b)
+	slices.SortFunc(list, func(a, b string) int {
+		return strings.Compare(strings.ToLower(a), strings.ToLower(b))
 	})
 	content := new(bytes.Buffer)
 	content.WriteString(authorsFileHeader)

Original file line number	Diff line number	Diff line change
`@@ -291,8 +291,8 @@ func writeAuthors(files []string) {`
`291`	`291`	`}`
`292`	`292`	`}`
`293`	`293`	`// Write sorted list of authors back to the file.`
`294`		`- slices.SortFunc(list, func(a, b string) bool {`
`295`		`- return strings.ToLower(a) < strings.ToLower(b)`
	`294`	`+ slices.SortFunc(list, func(a, b string) int {`
	`295`	`+ return strings.Compare(strings.ToLower(a), strings.ToLower(b))`
`296`	`296`	`})`
`297`	`297`	`content := new(bytes.Buffer)`
`298`	`298`	`content.WriteString(authorsFileHeader)`