Merge pull request #2256 from CortexFoundation/dev

ucwong · web-flow · commit 4b62543ffd63 · 2025-01-31T09:35:03.000Z
crypto: add IsOnCurve check
diff --git a/crypto/crypto.go b/crypto/crypto.go
@@ -179,6 +179,9 @@ func UnmarshalPubkey(pub []byte) (*ecdsa.PublicKey, error) {
 	if x == nil {
 		return nil, errInvalidPubkey
 	}
+	if !S256().IsOnCurve(x, y) {
+		return nil, errInvalidPubkey
+	}
 	return &ecdsa.PublicKey{Curve: S256(), X: x, Y: y}, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -179,6 +179,9 @@ func UnmarshalPubkey(pub []byte) (*ecdsa.PublicKey, error) {`
`179`	`179`	`if x == nil {`
`180`	`180`	`return nil, errInvalidPubkey`
`181`	`181`	`}`
	`182`	`+ if !S256().IsOnCurve(x, y) {`
	`183`	`+ return nil, errInvalidPubkey`
	`184`	`+ }`
`182`	`185`	`return &ecdsa.PublicKey{Curve: S256(), X: x, Y: y}, nil`
`183`	`186`	`}`
`184`	`187`