Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to favorites from inside a tool #1384

Open
ajpanton opened this issue Nov 8, 2024 · 4 comments
Open

Add to favorites from inside a tool #1384

ajpanton opened this issue Nov 8, 2024 · 4 comments
Assignees
Labels
bug Something isn't working triage

Comments

@ajpanton
Copy link

ajpanton commented Nov 8, 2024

Describe the bug

When viewing the grid of tools, you can click the heart to add a tool to your favorites. This works fine.

When opening a tool, there's the heart again in the upper-right corner. Here the heart does nothing.

What happened?

Nothing happens. I expected it to be added to my favorites. Similarly, if a tool is already in the favorites, clicking this heart doesn't remove it.

System information

Docker container, very vanilla settings, just a port mapping.

Where did you encounter the bug?

A self hosted

@ajpanton ajpanton added bug Something isn't working triage labels Nov 8, 2024
@gitmotion
Copy link
Contributor

gitmotion commented Nov 12, 2024

@ajpanton this should be fixed here: #1368

and it's working in it-tools.tech - by any chance have you pulled/redeployed with the latest version? you may need to clear cache and hard reload (ctrl + shift + r) after redeploying

@ajpanton
Copy link
Author

ajpanton commented Nov 12, 2024

This was with a completely fresh container, installed for the first time with no opportunities to get screwed up over time. But I recreated it again with :latest (same as before), destroying all data it might have stored somewhere, and the problem still persists.

Since I'm using Portainer, I can't (I think) see exactly what command it uses to create a container. So I tried creating a stack (Docker Compose):

services:
    it-tools:
        image: corentinth/it-tools:latest
        container_name: it-tools
        ports:
            - '8080:80'

No change.

@gitmotion
Copy link
Contributor

@ajpanton ah interesting, in that case you might want to try the nightly github package/image that should have all the newest changes: ghcr.io/corentinth/it-tools:nightly

services:
    it-tools:
        image: 'ghcr.io/corentinth/it-tools:nightly'
        container_name: it-tools
        restart: unless-stopped
        ports:
            - '8080:80'

@ajpanton
Copy link
Author

The nightly works, thanks! Well, it's not a feature I need, as I was able to work around it. Just wanted to report a bug (that apparently is already getting fixed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

3 participants