Repository navigation
Commit cfecaa4
Clean up every ruff finding and two thirds of the mypy ones
First lint and type pass over the build scripts. Neither tool is wired
into CI, so this is groundwork rather than a fix for anything failing.
ruff, 42 findings to 0:
- 38 auto-fixed: unused imports, f-strings with no placeholders, one
redefined-while-unused
- dropped two header lists in fix_members.py and sync_cv_people.py that
were read off the sheet and never used
- moved onboard_member.py's deferred dartmouth_chat import up with the
other module imports, carrying its explanatory comment along so the
mlx-lm rationale stays attached to the import it explains
mypy, 24 errors to 8, all of it annotation-only:
- annotated eight collections mypy could not infer, and the two implicit
Optional defaults in build_cv.run_command and add_borders
- declared member as Optional in offboard_member.py, since
prompt_for_selection can return None
- annotated add_borders' img as Image.Image: Image.open returns an
ImageFile but convert and crop return an Image
- onboard_member.py now narrows on `alumni_entry is not None` directly
rather than through an intermediate bool mypy cannot see through
The eight remaining mypy errors are all third-party stub limitations,
not defects: BeautifulSoup attribute lookups in extract_people.py,
Image.getpixel's union return, an re.subn overload, and one variable in
extract_cv.py that holds two shapes. extract_cv.py is the LaTeX to HTML
parser the CV build depends on, so it is not worth restructuring in the
same push as a CV change. Filed separately.
Verified behavior-neutral by rebuilding: publications.html, people.html,
software.html, news.html and JRM_CV.html all come back byte-identical,
and JRM_CV.pdf differs only in its embedded timestamp. ruff is clean and
the suite is 348 passed, 12 skipped.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QQUWxAFYESZCZe3DLyy1eB1 parent 6ac7d1a commit cfecaa4
22 files changed
Lines changed: 44 additions & 62 deletions
File tree
- scripts
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | | - | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
99 | 98 | | |
100 | 99 | | |
101 | 100 | | |
102 | | - | |
103 | 101 | | |
104 | 102 | | |
105 | 103 | | |
106 | 104 | | |
107 | 105 | | |
108 | | - | |
| 106 | + | |
109 | 107 | | |
110 | 108 | | |
111 | 109 | | |
| |||
441 | 439 | | |
442 | 440 | | |
443 | 441 | | |
444 | | - | |
| 442 | + | |
445 | 443 | | |
446 | 444 | | |
447 | 445 | | |
| |||
482 | 480 | | |
483 | 481 | | |
484 | 482 | | |
485 | | - | |
| 483 | + | |
486 | 484 | | |
487 | 485 | | |
488 | 486 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
440 | | - | |
| 440 | + | |
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | 26 | | |
28 | 27 | | |
29 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
146 | 147 | | |
147 | 148 | | |
148 | 149 | | |
149 | | - | |
| 150 | + | |
150 | 151 | | |
151 | 152 | | |
152 | 153 | | |
| |||
237 | 238 | | |
238 | 239 | | |
239 | 240 | | |
240 | | - | |
| 241 | + | |
241 | 242 | | |
242 | 243 | | |
243 | 244 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
26 | | - | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
0 commit comments