Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import custom LC dataset not working properly #862

Open
gdaldegan opened this issue Jan 7, 2025 · 9 comments
Open

Import custom LC dataset not working properly #862

gdaldegan opened this issue Jan 7, 2025 · 9 comments
Assignees

Comments

@gdaldegan
Copy link
Contributor

Only a subset of land cover classes is correctly imported when importing custom land cover datasets developed locally. For instance, tried to import a LC layer for the Bahamas originally containing 8 classes, but only 2 are shown after importing this layer into Trends.Earth using the function.

@Samweli Samweli added size: 3 It will take me between 2 hours to half a day. size: 5 It will take between half a day and a full day. and removed size: 3 It will take me between 2 hours to half a day. labels Jan 9, 2025
@Samweli
Copy link
Collaborator

Samweli commented Jan 9, 2025

@gdaldegan can you share the Bahamas layer, so I can test and figure out the underlying issue, thanks.

@mvmaltitz mvmaltitz removed the size: 5 It will take between half a day and a full day. label Jan 10, 2025
@Samweli
Copy link
Collaborator

Samweli commented Jan 13, 2025

@gdaldegan does the below screenshot show the expected import workflow and output?

Screenshot
image

GIF showing the whole process
lc_data_import

@gdaldegan
Copy link
Contributor Author

thanks @Samweli! Yes, this is the expected output after importing a custom land cover layer. What was preventing it to be correctly imported?

@Samweli
Copy link
Collaborator

Samweli commented Jan 13, 2025

thanks @Samweli! Yes, this is the expected output after importing a custom land cover layer. What was preventing it to be correctly imported?

@gdaldegan I haven't changed anything in the plugin code yet, I just restored the plugin land cover classes to their default state and ran the process. Can you share the screenshot/steps of you getting the error?

@gdaldegan
Copy link
Contributor Author

Both Sebastian and I followed the same workflow to import the LC dataset and this is the result:

image

@Samweli
Copy link
Collaborator

Samweli commented Jan 13, 2025

@gdaldegan what are the available LC classes in the settings and the land cover classes aggregation definition you are using when importing?
From my side I'm using the following

Custom LC classes(from the plugin settings) Aggregation of land cover(from the import dialog) Output
image image image

@gdaldegan
Copy link
Contributor Author

The land cover pixel values are as follows:
Cropland 0
Grassland 1
Bareground 2
Tree-covered 3
Urban 4
Water 5
Wetland 6

@Samweli
Copy link
Collaborator

Samweli commented Jan 13, 2025

The land cover pixel values are as follows: Cropland 0 Grassland 1 Bareground 2 Tree-covered 3 Urban 4 Water 5 Wetland 6

Thanks @gdaldegan, can you take a screenshot of these classes as defined in the plugin settings and the aggregation land cover definition tool and share them. If not, can we schedule a meeting so we can look at these classes definitions together.

@gdaldegan
Copy link
Contributor Author

image

@Samweli here's the screenshot. Just went through the steps again, now resetting to default, and the imported dataset still showing only 3 classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants