-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graph based on for time period comparison #857
base: main
Are you sure you want to change the base?
Add graph based on for time period comparison #857
Conversation
for more information, see https://pre-commit.ci
Timeline progress period
for more information, see https://pre-commit.ci
Added graph for progress period : Screen.Recording.2024-12-03.at.14.20.11.mov |
Thanks! Flagging @boc84 for his review as well |
Looks good. My first comment is about the terminology. I am not sure if we will be using the term "Progress" or ""SDG Status" anymore but this under discussion and not likely resolved until next year. I wonder could we maintain the functionality as is but allow flexibility to change the text later. Secondly, if you check the first slide on this PPT, in the "old" way of calculating the SDG we used the full 20-year time series for SOC change in the reporting period. Please make sure this is possible in the current implementation. Thirdly, are there constraints on the min and max year a country can report for either period? For example, should we prevent years beyond 2023 being selected? Or enforce a maximum number of years between initial and final years for a given dataset? |
For #856
Screen.Recording.2024-12-01.at.14.54.37.mov