Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graph based on for time period comparison #857

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dimasciput
Copy link
Collaborator

For #856

Screen.Recording.2024-12-01.at.14.54.37.mov

@dimasciput dimasciput changed the title Add graph based on baseline period Add graph based on for time period comparison Dec 3, 2024
@dimasciput
Copy link
Collaborator Author

Added graph for progress period :

Screen.Recording.2024-12-03.at.14.20.11.mov

@amyburness amyburness linked an issue Dec 4, 2024 that may be closed by this pull request
1 task
@azvoleff
Copy link
Contributor

azvoleff commented Dec 6, 2024

Thanks! Flagging @boc84 for his review as well

@boc84
Copy link
Collaborator

boc84 commented Dec 6, 2024

Looks good. My first comment is about the terminology. I am not sure if we will be using the term "Progress" or ""SDG Status" anymore but this under discussion and not likely resolved until next year. I wonder could we maintain the functionality as is but allow flexibility to change the text later.

Secondly, if you check the first slide on this PPT, in the "old" way of calculating the SDG we used the full 20-year time series for SOC change in the reporting period. Please make sure this is possible in the current implementation.

Thirdly, are there constraints on the min and max year a country can report for either period? For example, should we prevent years beyond 2023 being selected? Or enforce a maximum number of years between initial and final years for a given dataset?
Default_Data_SDG_Progress_Calculation (003).pptx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design and implement technical solutions for time period comparison - Add UI
3 participants