Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with third party apps: Develop the documentation of JSON format #825

Open
amyburness opened this issue Jul 4, 2024 · 8 comments

Comments

@amyburness
Copy link
Collaborator

amyburness commented Jul 4, 2024

Develop the documentation of JSON format used for data transfer to PRAIS, including the JSON schema used to transfer results from Trends.Earth to PRAIS. Additionally, the documentation should enable other platforms to output data for ingestion into PRAIS without referring to the Trends.Earth codebase. Additionally, make any recommendations for simplification of the format or other improvements that could improve usability and reliability during data transfer.

@amyburness
Copy link
Collaborator Author

amyburness commented Jul 4, 2024

  • Documentation of JSON format used to transfer data between Trends.Earth and PRAIS.

@Samweli Samweli added the size: 40 Ouch this is going to take a week. label Jul 19, 2024
@amyburness amyburness added this to the Kartoza Support 2024 milestone Sep 15, 2024
@amyburness
Copy link
Collaborator Author

amyburness commented Oct 30, 2024

A few key improvements that could be made to the JSON from my (@azvoleff ) perspective are:

Drought

  • Shift geojson for AOI outside of summary json and into a separate geojson linked via a STAC
  • Record metadata on the climate dataset (precpitation and possible evapotranspiration) and index (SPI or SPEI) used, as well as the timescale used for the calculation of the index

Land degradation

  • Shift geojson for AOI outside of summary json and into a separate geojson linked via a STAC
  • Shift geojson for false positive / negatives outside of summary json and into a separate geojson linked via a STAC
  • Need to handle multiple time periods for reporting. Right now the JSON is setup to handle online one baseline period and one reporting period. Suggest revising the dictionary keys used under ["results"]["data"]["report"]["land_condition"]
  • Consolidate mentions of the land cover legend so that it is only listed once per sub-indicator (land cover, SOC, and productivity). But retain ability to vary land cover legend by sub-indicator
  • Support arbitrary period names for the periods listed under ["results"]["data"]["report"]["land_condition"] (as these will be assignable within Trends.Earth for user convenience / to aid in internationalization, etc.)
  • Remove tables that are no longer needed due to revisions in PRAIS (need to connect with @Vlad Posea and @Brian O'Connor on this). For example SOC crosstabs that have been dropped from PRAIS
  • Need to support some kind of metadata on sub-national analyses? (question for discussion with @Brian O'Connor)

Across both drought/land deg JSONs

  • Need for further sanity checks w/in Trends.Earth to ensure values are consistent within JSON and across drought/land degradation JSONs prior to submission to UNCCD (ensuring class areas are consistent across years and with AOI, that values are valid, etc.)

@amyburness
Copy link
Collaborator Author

amyburness commented Oct 30, 2024

there are multiple reporting periods-> these need keys
where the legend is identical we need to remove duplication.
we need the final tables from PRAIS
the output metadata needs to include the metadata of the users options chosen in the analysis in addition to the dataset chosen.

@amyburness
Copy link
Collaborator Author

See JSON review meeting with UNCCD here: https://drive.google.com/file/d/1gkyCqsT-Nooa2GQLblQgW5kDooh2RvKT/view?usp=drive_link

@amyburness
Copy link
Collaborator Author

@amyburness
Copy link
Collaborator Author

amyburness commented Nov 22, 2024

Task list:

  • Shift geojson for AOI outside of summary json and into a separate geojson linked via a STAC for both drought and Land degradation.
  • Shift geojson for false positive / negatives outside of summary json and into a separate geojson linked via a STAC for Land degradation.

@mvmaltitz mvmaltitz added Feedback Pending and removed size: 40 Ouch this is going to take a week. labels Jan 8, 2025
@mvmaltitz mvmaltitz added the UR13 label Jan 17, 2025
@mvmaltitz
Copy link
Collaborator

mvmaltitz commented Jan 29, 2025

@Samweli

The folder contains all the files per SO, but kindly note that the modifications we made are kept in track changes in the word documents for clarity.

https://unccd.sharepoint.com/:f:/s/CRIC/ElSvtGPFd1RMhbxJyV9XQJ0BpHScYnFBHYVc7u4h5Ac1DQ

I have copied the reports to here in case access is a problem in the future:
https://drive.google.com/drive/u/0/folders/1h_U2zWDEa0JBK3mUmbEr8kk4Rpku1Szq

@mvmaltitz
Copy link
Collaborator

@Samweli Please refer to the following email:

Image

We have made progress on the SO1 forms, and they are 90% finished with just a few details still needing finalization. According to the agreed schedule we will have these finished by end of February.

Coleen already shared the link to the parent folder but you can find the current version of the SO 1 forms in Word here:

​docx icon SO1-Forms_merged clean.docx

Please note that new additions to the old forms are highlighted in track changes for ease of reference as are items that have been deleted.

We also have new tables which will go in a new country profile section. You can find them here:

​docx icon Country Profile.docx

@Vlad Posea Please have a look through these carefully and read our comments before Thursday’s meeting then we can discuss what question/comments you have. We can also meet before then and have a dedicated meeting on SO1 if you want to.

@[email protected] you will want to ensure the JSON has the necessary data structures (and geospatial layers) to populate these tables so you can already carefully check the forms. As the SO1 tables will not be implemented in the PRAIS system until end March, these Word versions of the forms will be your best guide for the developers. Let us know when have you gone through them and need to discuss anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants