New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handel constructor simplification #130

Open

nikkolasg opened this issue May 21, 2019 · 0 comments

Collaborator

nikkolasg commented May 21, 2019 •

edited

Loading

At the moment, the Handel constructor looks like the following:

func NewHandel(n Network, r Registry, id Identity, c Constructor,msg []byte, s Signature, conf ...*Config) *Handel

I see two problems with that:

It is very long: 7 arguments is long, even more for Go. And it add quite a cognitive load to be able to understand all these arguments and set them properly.
The Config contains the "Contributions" field that may required to be changed. Of course one can take the default value, but if a users sets it one time, it has to set it all the other times as well when the number of ids change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment