Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0 Crashed my entire site - (Resolved) #238

Open
wagonmonster opened this issue Nov 17, 2022 · 33 comments
Open

Version 3.0 Crashed my entire site - (Resolved) #238

wagonmonster opened this issue Nov 17, 2022 · 33 comments

Comments

@wagonmonster
Copy link

wagonmonster commented Nov 17, 2022

2022/11/17 23:47:22 [error] 131032#131032: *208666 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught Error: Class 'ScssPhp\ScssPhp\Block\CallableBlock' not found in /www/site-name/public/wp-content/plugins/wp-scss/scssphp/src/Parser.php:494
Stack trace:
#0 /www/site-name/public/wp-content/plugins/wp-scss/scssphp/src/Parser.php(287): ScssPhp\ScssPhp\Parser->parseChunk()
#1 /www/site-name/public/wp-content/plugins/wp-scss/scssphp/src/Compiler.php(5707): ScssPhp\ScssPhp\Parser->parse('// Bootstrap fu...')
#2 /www/site-name/public/wp-content/plugins/wp-scss/scssphp/src/Compiler.php(2673): ScssPhp\ScssPhp\Compiler->importFile('/www/.....', Object(ScssPhp\ScssPhp\Formatter\OutputBlock))
#3 /www/site-name/public/wp-content/plugins/wp-scss/scssphp/src/Compiler.php(2885): ScssPhp\ScssPhp\Compiler->compileImport(Array, Object(ScssPhp\ScssPhp\Formatter\OutputBlock))
#4 /www/site-name/public/wp-content/plugins/wp-scss/scssphp/src/Compiler.php(2348): ScssPhp\ScssPhp\Compiler->compileChild(Array, Object(ScssPh" while reading response header from upstream, client: 67.180.119.64, server: site-name.com, request: "GET /wp-admin/plugins.php?activate=true&plugin_status=all&paged=1&s= HTTP/1.1",

@neilparnold
Copy link

Same error on a bunch of my sites. Had to disable the plugin.

@wagonmonster
Copy link
Author

I have literally used this plugin on at least 20 sites. I am madly trying to disable auto updates on all of them before all hell breaks loose.

PLEASE FIX THIS!

@andreasjr
Copy link

Came here to say the same thing. We have the plugin on about 77 sites, and it took down 4, so I'm deactivating it before it takes down the rest.

From what my colleague told me, having "always recompile" enabled before the update crashed it. Rolling back, disabling that option, and updating the plugin seemed to work.

@sylvainNascimento
Copy link

Same ! Crash on update !

@tomte2000
Copy link

@andreasjr -> that only works if you don't compile. as soon you compile a changed sass-file the error comes again.
only solution is to go back to last version…

@bene82
Copy link

bene82 commented Nov 18, 2022

I confirm that compiling (without check on automatic compiling) I get a fatal error.

@Quentin64600
Copy link

Same here, some websites crashed

@aduchenet
Copy link

aduchenet commented Nov 18, 2022

It can be solved by replacing the embedded scssphp directory by the latest version of https://scssphp.github.io/scssphp/ .

The published (on Wordpress.com) archive of the plugin does not contain the same version of scssphp than this repository sources.

@airplanenoise
Copy link

+1, we had to rollback https://wordpress.org/plugins/wp-rollback/ - hopefully this will be fixed by an emergency update as it does affect many sites for many people.

@foinf
Copy link

foinf commented Nov 18, 2022

+1 It borked a live site that I know of and I am sure it crashed other sites that use as well and now I am having to go through all the other sites to find out. How did this happen?

@rileeugenia
Copy link

rileeugenia commented Nov 18, 2022

+1
Crash on update !
Fatal error: Uncaught Error: Class 'ScssPhp\ScssPhp\Block\MediaBlock' ... in /xxxxxxx/xxxx//wp-content/plugins/wp-scss/scssphp/src/Parser.php on line 477

@agkovalev
Copy link

+1
Sites with autoupdate enabled crashed.

@howardperkins
Copy link

Here's a link to v2.4 for the time being: https://github.com/ConnectThink/WP-SCSS/archive/refs/tags/2.4.0.zip

If you have access to your site's filesystem then delete the old plugin folder at wp-content/plugins/wp-scss and replace it with the above, renaming the folder to wp-scss. Your site should return to normal until the devs provide a fixed update.

@dltownsend3
Copy link

Same issue here. Crashed 6 of my company's sites. Not sure I can trust this plugin again, as this shouldn't have even been possible in my mind, and it crashed the sites in such a way that a notice couldn't even be sent to the admin email. Had to hear about it from a client - the worst case scenario.

@wagonmonster
Copy link
Author

I switched all my sites over to another SCSS Compiler plugin, I can't trust these guys anymore.

@foinf
Copy link

foinf commented Nov 18, 2022

I switched all my sites over to another SCSS Compiler plugin, I can't trust these guys anymore.

This was beyond painful and is still going on...I have to go through more than 80 sites where I have used it. I am still sifting through them one by one. The amount of stress this has created has never happened to me in 8 years. I can't believe this actually happened.

@foinf
Copy link

foinf commented Nov 18, 2022

How long before the author atleast take the defective update offline so that more damage may be prevented?

Can wordpress be contacted to take the auto update offline?

@wagonmonster
Copy link
Author

I switched all my sites over to another SCSS Compiler plugin, I can't trust these guys anymore.

This was beyond painful and is still going on...I have to go through more than 80 sites where I have used it. I am still sifting through them one by one. The amount of stress this has created has never happened to me in 8 years. I can't believe this actually happened.

I feel your pain, it's ridiculous this happened and it's infuriating that they haven't fixed it yet.

@foinf
Copy link

foinf commented Nov 18, 2022

I think such gross incompetence should be reason enough for WordPress to immediately delist this from its plugin library. I can't go through these sites fast enough and I fear many might be broken or about to break.

@airplanenoise
Copy link

i had had an issue in the past with this plugin and i mostly have it setup to disable auto-updates. i don't want to yell at the developer of this plugin, it's brought great productivity to our development flow. it's not a paid plugin. i think of it as a "sleepy plugin", i was actually surprised there was an update. we do rely on it quite a bit, but it's only an issue if you autoupdate, so let's learn from that. just curious @wagonmonster what is the compiler you use? hopefully this will be fixed soon. i just got an email from another developer saying that the latest update caused a fatal error — that at least is helpful: if there is a way for the owner of the plugin to send a message to all people that installed it that might help!

@dltownsend3
Copy link

dltownsend3 commented Nov 18, 2022

I think such gross incompetence should be reason enough for WordPress to immediately delist this from its plugin library. I can't go through these sites fast enough and I fear many might be broken or about to break.

@foinf I had the compiled stylesheet link hardcoded so I was able to bring my sites back up by just renaming the plugin folder to disable it, might work for you or anyone else who set their sites up that way.

@foinf
Copy link

foinf commented Nov 18, 2022

I know and that's what I am doing but there are many sites. Also imagine the plight of someone who has to check up on even more sites like 150+. This is nothing short of an absolute nightmare.

@KustomKode
Copy link

KustomKode commented Nov 19, 2022

THIS IS A SUPER SIMPLE FIX

Although it shouldn't have been released before being tested for quality assurance, accidents happen, luckily as a developer who has had many accidents in my career, I have become pretty good at troubleshooting.

The simplest fix is to FTP into your site and go to the "scss" plugin folder, open it and delete the entire folder named "scssphp" and replace it with a new folder of the same name and put the files from https://github.com/scssphp/scssphp/ inside of it. It takes less than 60 seconds to fix.

And if you haven't updated to version 3.0 on a site yet, just don't update it until there is a version released with a version number greater than 3.0. Problem solved.

@lakuapik
Copy link

lakuapik commented Nov 19, 2022

What i found is: for some reason, the version that wordpress plugin downloaded does not contain the scssphp/src/Block directory, which is i believe required to compile the scss.

From wordpress plugin

image

From github release

image

so i dont think its the developer to blame but how the plugin delivery is. #cmiiw

@lakuapik
Copy link

if you still want to use the version 3.0.0, the hotfix is you need to upload the scssphp/src/Block directory to your wp-scss plugin. I've tried and it works.

before:

image

after:

image

@bene82
Copy link

bene82 commented Nov 26, 2022

Ok. So we can close the issue downloading the plugin from Github and not updating with WordPress.

@wagonmonster
Copy link
Author

Ok. So we can close the issue downloading the plugin from Github and not updating with WordPress.

It's still broken, so no, don't close it.

@foinf
Copy link

foinf commented Nov 29, 2022

Ok. So we can close the issue downloading the plugin from Github and not updating with WordPress.

It's still broken, so no, don't close it.

The problem update is still out there breaking sites. Just happened to me a couple of hours ago, thankfully, on a staging site. Is there no way of taking it offline?

@agkovalev
Copy link

agkovalev commented Nov 30, 2022

Just add folder Block to scssphp folder. You can find it on github https://github.com/scssphp/scssphp/releases/tag/v1.10.0

@arekuki
Copy link

arekuki commented Dec 5, 2022

+1

@nbaudet
Copy link

nbaudet commented Dec 13, 2022

I did a PR that I mention in this issue.

@shadoath
Copy link
Collaborator

So sorry for this long wait to fix this issue. I only receive notifications with direct @shadoath mentions.

I mistakenly missed some files when committing to WordPress SVN for version 3.0.0 (Wish wish wish they used git and tags for versioning)

This is now fixed in version 4.0.2. Which also requires PHP 7.2

I also pushed version 3.0.2 with a fix for just that major version and the missing files.

If you would like to help maintain this plugin, please reach out here.

@shadoath
Copy link
Collaborator

There are a lot of comments here complaining. When I read this it is like seeing a little kid in a tantrum. Sorry for the inconvenience and trouble.

Then there are some who took action and found how to fix this issue and then offered it up to others. Bravo!

I was happy to find this comment:

... i don't want to yell at the developer of this plugin, it's brought great productivity to our development flow. it's not a paid plugin. i think of it as a "sleepy plugin", i was actually surprised there was an update. we do rely on it quite a bit, but it's only an issue if you autoupdate, so let's learn from that....]

Thank you for giving your insight in calm and collected way. I pushed it out as v3.0.0 thinking it would require a manual update as it was a major version change and would not cause so many issues from auto-updating, I was wrong.

hopefully this will be fixed soon. i just got an email from another developer saying that the latest update caused a fatal error — that at least is helpful: if there is a way for the owner of the plugin to send a message to all people that installed it that might help!

This is helpful! I'll look into the email option I didn't know that a plugin author could do that. I'm only a maintainer so I'll have to see if I have that option on WordPress.

My last update was a rush and dealing with SVN is not as smooth as with Git, which lead me to miss a few files and caused this blowup. I updated my website and moved on not realizing this issue shows as soon as a new compile tries to run.

As I noted above I think having another maintainer who is active with this plugin would be a big help for stability and adding features.

@shadoath shadoath pinned this issue Jan 16, 2023
@shadoath shadoath changed the title Version 3.0 Crashed my entire site Version 3.0 Crashed my entire site - (Resolved) Jan 16, 2023
@gcwebsites gcwebsites unpinned this issue Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests