add start_newPendingTransactions_loop #2690
Conversation
|
Can one of the admins verify this patch? |
|
ok to test |
|
There is no such a channel, and that's probably why One possible choice is to create a new channel for this and push successfully inserted transaction hashes in |
|
@peilun-conflux I just created a new channel |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @waelsy123)
client/src/rpc/impls/eth_pubsub.rs line 117 at r2 (raw file):
let fut = async move { while let Some(new_tx) = receiver.recv().await { debug!("new_pending_transactions_loop: {:?}", new_tx);
Since transactions can be received very fast, it's better to remove this or change it to trace!.
client/src/rpc/impls/eth_pubsub.rs line 292 at r2 (raw file):
// notify each subscriber about new pending transaction `hash` concurrently fn notify_new_pending_transaction(&self, hash: H256) {
Same about the log level here.
Looks good to me. BTW, you need to run |
|
@peilun-conflux thank you for the feedback! regarding the formating, seems like rustup doesn't support my m1 mac arch, I'm getting this error: it's worth to mention I'm using I'm curious why do we use hardcoded |
|
There are already flashbots working in the mempool of Conflux. Is a beta version out? |
|
@waelsy123 can you fix the conflict issue? |
|
@Pana sure will fix it |
|
@Pana is that still valid PR? |
This change is
Support for new pending transactions pubsub #2672
[WIP]
do we have a notification Channel to subscribe for when new pending transaction? so far I'm using the new_block_hashes channel