Skip to content

Commit bf04614

Browse files
committed
make cellRendererFramework obselete
1 parent 9477b16 commit bf04614

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

demo/src/Components.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ let Demo () =
249249
ColumnDef.headerName "Total"
250250
ColumnDef.columnType ColumnType.NumericColumn
251251
ColumnDef.valueGetter (fun x -> x.Total)
252-
ColumnDef.cellRendererFramework (fun x _ ->
252+
ColumnDef.cellRenderer (fun x _ ->
253253
Html.span [
254254
Html.span [
255255
prop.style [ style.fontSize 9 ]
@@ -377,7 +377,7 @@ Html.div [
377377
ColumnDef.headerName "Total"
378378
ColumnDef.columnType ColumnType.NumericColumn
379379
ColumnDef.valueGetter (fun x -> x.Total)
380-
ColumnDef.cellRendererFramework (fun x _ ->
380+
ColumnDef.cellRenderer (fun x _ ->
381381
Html.span [
382382
Html.span [
383383
prop.style [ style.fontSize 9 ]

src/AgGrid.fs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// fsharplint:disable
22
module Feliz.AgGrid
33

4+
open System
45
open Fable.Core
56
open Fable.Core.JsInterop
67

@@ -61,7 +62,10 @@ type ColumnDef<'row, 'value> =
6162
static member inline autoComparator = columnDefProp<'row, 'value> ("comparator" ==> compare)
6263
static member inline cellClass (setClass:'value -> 'row -> #seq<string>) = columnDefProp<'row, 'value> ("cellClass" ==> fun p -> setClass p?value p?data |> Seq.toArray)
6364
static member inline cellClassRules (rules: (string*('value -> 'row -> bool)) list) = columnDefProp<'row, 'value> ("cellClassRules" ==> (rules |> List.map (fun (className, rule) -> className ==> fun p -> rule p?value p?data) |> createObj))
64-
static member cellRendererFramework (render:'value -> 'row -> ReactElement) = columnDefProp<'row, 'value> ("cellRenderer" ==> fun p -> CellRendererComponent(render, p))
65+
66+
[<Obsolete("cellRendererFramework isn't supported in the latest version of AgGrid. Use cellRenderer instead", true)>]
67+
static member cellRendererFramework _ = failwith "cellRendererFramework isn't supported in the latest version of AgGrid. Use cellRenderer instead"
68+
static member cellRenderer (render:'value -> 'row -> ReactElement) = columnDefProp<'row, 'value> ("cellRenderer" ==> fun p -> CellRendererComponent(render, p))
6569
static member inline cellStyle (setStyle:'value -> 'row -> _) = columnDefProp<'row, 'value> ("cellStyle" ==> fun p -> setStyle p?value p?data)
6670
static member inline checkboxSelection (v:bool) = columnDefProp<'row, 'value> ("checkboxSelection" ==> v)
6771
static member inline colId (v:string) = columnDefProp<'row, 'value> ("colId" ==> v)

0 commit comments

Comments
 (0)