-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibly out of date entry for features #10
Comments
Thanks @aezarebski for pointing out that the features table is ridiculously out of date. The epoch substitution model indeed exists in BEASTLabs, but there are a lot of other models that are not featured in the table. BEAST has been developing rapidly and we should have a better mechanism for keeping the table current with the latest packages. |
Thanks for the updates -- I had a short discussion yesterday with Walter about adding this information to CBAN, perhaps as part of packages2.6.xml or a separate features file. At the time of adding packages to BEAST it seems a good time to clarify features as well. Every time this information is committed the features table can then be updated automatically, which seems more robust than having it updated by hand. |
No worries, happy to help. Reading it from the XML sounds like a pretty optimal solution, and I suppose you could use the existing entries to fill in the fields for the existing packages initially. Having the information for analogous features in BEAST1.X sounds like it could be annoying though. I'll leave this issue for you to close in case you want the thread as a reminder. |
While checking to see if epoch models were supported by BEAST2 I see on the features page that they are not.
https://www.beast2.org/features/miscellaneous-epoch-models.html
the relevant line of code in this repository seems to be the following
beast2-site/_features/miscellaneous-epoch-models.md
Line 5 in 90745d8
Based on this blog post
beast2-site/_posts/2019-02-25-epoch-models.html
Line 9 in 90745d8
it looks like epoch models are now supported with BEASTLabs.
Could you please update the features table, or if I have misunderstood, could a clarifying comment please be included explaining the current entry?
p.s., just trying to help :)
beast2-site/_pages/features.html
Line 8 in 5e516fa
The text was updated successfully, but these errors were encountered: