Skip to content

Commit d780c4e

Browse files
committed
[web] fix members modal scrolling behavior
Summary: This diff address a bug where the members list was not scrolling with the new refactored tabs I introduced a few weeks ago. Linear task: https://linear.app/comm/issue/ENG-6470/cant-scroll-members-modal-on-web Test Plan: Please see the demo video below + also doubled checked with every place that uses the new refactored tabs that they did not have also have any regressions with the scrolling {F1072024} Reviewers: atul, inka Reviewed By: inka Subscribers: ashoat, tomek Differential Revision: https://phab.comm.dev/D10732
1 parent 715cc10 commit d780c4e

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

web/modals/threads/members/members-modal.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ div.modalContentContainer {
66
row-gap: 16px;
77
}
88

9-
div.membersListTabs {
9+
div.membersListTabsContent {
1010
flex: 1;
1111
overflow: hidden;
1212
}
@@ -16,8 +16,8 @@ div.addNewMembers button {
1616
}
1717

1818
div.membersList {
19-
overflow: auto;
20-
padding: 8px 0;
19+
height: 100%;
20+
overflow-y: scroll;
2121
color: var(--members-modal-member-text);
2222
}
2323

web/modals/threads/members/members-modal.react.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,8 @@ function ThreadMembersModalContent(props: ContentProps): React.Node {
114114
const threadMembersModalContent = React.useMemo(
115115
() => (
116116
<div className={css.modalContentContainer}>
117-
<div className={css.membersListTabs}>
118-
{tabs}
119-
{tabContent}
120-
</div>
117+
{tabs}
118+
<div className={css.membersListTabsContent}>{tabContent}</div>
121119
{addMembersButton}
122120
</div>
123121
),

0 commit comments

Comments
 (0)