Skip to content

Commit e71edb1

Browse files
authored
Merge pull request #4 from duckcomfy/refactor/address_review
refactor/address review
2 parents 3db8b8c + dfcd360 commit e71edb1

File tree

10 files changed

+65
-144
lines changed

10 files changed

+65
-144
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
"vite-plugin-html": "^3.2.2",
7070
"vite-plugin-vue-devtools": "^7.7.6",
7171
"vitest": "^2.0.0",
72-
"vue-tsc": "^2.2.12",
72+
"vue-tsc": "^2.1.10",
7373
"zip-dir": "^2.0.0",
7474
"zod-to-json-schema": "^3.24.1"
7575
},

src/extensions/core/load3d/CameraManager.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export class CameraManager implements CameraManagerInterface {
1414
orthographicCamera: THREE.OrthographicCamera
1515
activeCamera: THREE.Camera
1616

17+
// @ts-expect-error unused variable
1718
private renderer: THREE.WebGLRenderer
1819
private eventManager: EventManagerInterface
1920
private nodeStorage: NodeStorageInterface

src/extensions/core/load3d/ControlsManager.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
export class ControlsManager implements ControlsManagerInterface {
1111
controls: OrbitControls
1212

13+
// @ts-expect-error unused variable
1314
private eventManager: EventManagerInterface
1415
private nodeStorage: NodeStorageInterface
1516
private camera: THREE.Camera

src/extensions/core/load3d/SceneManager.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ export class SceneManager implements SceneManagerInterface {
2222

2323
private getActiveCamera: () => THREE.Camera
2424

25+
// @ts-expect-error unused variable
2526
private getControls: () => OrbitControls
2627

2728
constructor(

src/extensions/core/load3d/ViewHelperManager.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export class ViewHelperManager implements ViewHelperManagerInterface {
1212
private getControls: () => OrbitControls
1313
private nodeStorage: NodeStorageInterface
1414

15+
// @ts-expect-error unused variable
1516
private renderer: THREE.WebGLRenderer
1617

1718
constructor(

0 commit comments

Comments
 (0)