Skip to content
This repository has been archived by the owner on Apr 14, 2020. It is now read-only.

Graphic_Flicker compatibility #1075

Open
Alicecomma opened this issue Feb 29, 2020 · 2 comments
Open

Graphic_Flicker compatibility #1075

Alicecomma opened this issue Feb 29, 2020 · 2 comments

Comments

@Alicecomma
Copy link
Contributor

Several mods use Graphic_Flicker for nicer projectiles, however the ProjectileCE's ShadowMaterial class assumes GetColoredVersion exists for the graphic class, which isn't the case for Graphic_Flicker. ProjectileCE should be changed or Graphic_Flicker should get a CE version to make this work.

@Alicecomma
Copy link
Contributor Author

Approaches

  • Do not add a shadowMaterial whenever ShadowMaterial == null (very broad, simple)
    • Ignore the errorOnce by reflection, adding the tag "66800" to Log.usedKeys (less broad, difficult)
  • Prefix Graphic_Flicker.GetColoredVersion and write a working function (very specific, difficult)
  • Do not add a shadowMaterial whenever Graphic_Flicker is used (very specific, simple)

@Alicecomma
Copy link
Contributor Author

Writing a separate CE version of the graphic might be easiest. Extend Graphic_Flicker but override GetColoredVersion to one which uses cached, black versions of its subgraphics. Match its output with the latest output from the material getter class.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant