Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: implement quantum problem set filter #278

Closed
wants to merge 13 commits into from
Closed

FEAT: implement quantum problem set filter #278

wants to merge 13 commits into from

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Aug 8, 2024 •
edited
Loading

Temporary PR for feedback

@redeboer redeboer added the ✨ Feature New feature added to the package label Aug 8, 2024
@ComPWA ComPWA deleted a comment from review-notebook-app bot Aug 8, 2024
@redeboer
Copy link
Member Author

redeboer commented Aug 8, 2024

Btw please reopen this PR from your account, then the final squashed commit will be authored by you and I can approve the PR ;)

redeboer
redeboer commented Aug 8, 2024
View reviewed changes
tests/unit/test_solving.py Outdated Show resolved Hide resolved
tests/unit/test_solving.py Outdated Show resolved Hide resolved
tests/unit/test_solving.py Outdated Show resolved Hide resolved
tests/unit/test_solving.py Outdated Show resolved Hide resolved
redeboer
redeboer commented Aug 8, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
@redeboer redeboer mentioned this pull request Aug 9, 2024
Closed
@redeboer redeboer linked an issue Aug 9, 2024 that may be closed by this pull request
Write example that finds J^PC numbers with CSPSolver directly #272
Closed
@redeboer
Copy link
Member Author

This PR needs to be reopened by @grayson-helmholz (for eventually authoring the squashed commit). But better to do so after addressing the feedback first.

@redeboer redeboer removed a link to an issue Oct 4, 2024
Write example that finds J^PC numbers with CSPSolver directly #272
Closed
@redeboer redeboer mentioned this pull request Oct 4, 2024
Merged
@grayson-helmholz grayson-helmholz linked an issue Oct 22, 2024 that may be closed by this pull request
Give an example for the usage of the filter_quantum_number_problem_set-function in a notebook #297
Closed
@grayson-helmholz grayson-helmholz linked an issue Nov 5, 2024 that may be closed by this pull request
CSPSolver generates undesired edge_properties after filtering #301
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@grayson-helmholz grayson-helmholz

Labels
✨ Feature New feature added to the package
Projects
None yet
Milestone
No milestone
2 participants
@redeboer @grayson-helmholz